-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Make iOS WebView delegates virtual #27601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚨 API change(s) detected @davidbritch FYI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt: Language not supported
jsuarezruiz
reviewed
Feb 6, 2025
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
8228059
to
ae9b396
Compare
ae9b396
to
c70f6aa
Compare
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
mattleibow
approved these changes
Feb 10, 2025
/azp run |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Makes the
MauiWebViewNavigationDelegate
methods virtual so people can override these.Issues Fixed
Fixes #7551