Skip to content

Use TCS for BusySetSignalName tests #27583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

PureWeen
Copy link
Member

@PureWeen PureWeen commented Feb 5, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings February 5, 2025 15:45
@PureWeen PureWeen requested a review from a team as a code owner February 5, 2025 15:45
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (3)

src/Controls/tests/Core.UnitTests/PageTests.cs:301

  • [nitpick] The variable name 'tcs' is ambiguous. It should be renamed to 'busySignalTask' for better readability.
TaskCompletionSource tcs = new TaskCompletionSource();

src/Controls/tests/Core.UnitTests/PageTests.cs:324

  • [nitpick] The variable name 'tcs' is ambiguous. It should be renamed to 'busySignalTask' for better readability.
TaskCompletionSource tcs = new TaskCompletionSource();

src/Controls/tests/Core.UnitTests/PageTests.cs:348

  • [nitpick] The variable name 'tcs' is ambiguous. It should be renamed to 'busySignalTask' for better readability.
TaskCompletionSource tcs = new TaskCompletionSource();

@PureWeen PureWeen added this to the .NET 9 SR4 milestone Feb 5, 2025
@rmarinho rmarinho merged commit 9b5a0e1 into main Feb 5, 2025
24 of 69 checks passed
@rmarinho rmarinho deleted the tcs_BusySentWhenVisiblePageSetToBusy branch February 5, 2025 17:55
@github-actions github-actions bot locked and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants