[Windows] - Resolved FlyoutBehavior "Locked" State Reset Issue After Navigation #27379
Conversation
sheiksyedm
added
the
partner/syncfusion
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
| App.Tap("SecondPageButton"); | ||
| App.WaitForElement("GoBackButton"); | ||
| App.Tap("GoBackButton"); | ||
| VerifyScreenshot(); |
There was a problem hiding this comment.
Pending snapshots. Already available in the latest build. For example:
Could you commit the images?
There was a problem hiding this comment.
@jsuarezruiz, Thank you for highlighting this! In the latest commit, the test case was updated by replacing VerifyScreenShot with WaitForNoElement to ensure the absence of the Flyout icon. This modification eliminates the need to add snapshots for the test.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
github-actions
bot
force-pushed
the
fix-27337
branch
from
9c4d1d6 to
da0ea0a
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
|
Hi! Unfortunately, this change was not a good solution. Reason: In the delegate "getDefaultNavBarIsVisible" the current FlyoutBehavior value of the _shell is no longer accessed, but rather the previously determined value.
After navigating to another page in the app and navigating back again, the visibility of the drawer toggle button is no longer updated correctly when the FlyoutBehavior is changed from the state "Locked" to "Flyout" This is exactly the case I have in my app now. |
Root Cause
The visibility of the FlyoutIcon is determined by the DrawerToggleVisible value. In ShellView, the condition for DrawerToggleVisible was solely based on the StackCount and did not account for scenarios where the Shell was in the Flyout state. This caused the DrawerToggleVisible to return true incorrectly, leading to the FlyoutIcon displayed after back navigation.
Description of Change
Updated the DrawerToggleVisible value to account for FlyoutBehavior, ensuring that the FlyoutIcon visibility accurately reflects the Shell's Flyout state. This prevents the FlyoutIcon from being incorrectly displayed after navigation when the Shell is in Disabled and Locked mode.
Issues Fixed
Fixes #27337
Tested the behaviour in the following platforms
Ouput
BeforeFix.mp4
AfterFix.mp4