Fixed the vertical orientation issue in the CarouselViewHandler2 on iOS #27273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @Ahamed-Ali! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
karthikraja-arumugam
added
the
partner/syncfusion
jsuarezruiz
added
the
area-controls-collectionview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
tj-devel709
previously approved these changes
Jan 27, 2025
rmarinho
approved these changes
Jan 29, 2025
|
/rebase |
github-actions
bot
force-pushed
the
fix-27241
branch
from
3a80af3 to
8e78f45
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/rebase |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
github-actions
bot
force-pushed
the
fix-27241
branch
from
8e78f45 to
db1fd31
Compare
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause of the issue
OrthogonalScrollingBehaviorof the NsCollectionLayoutSection was previously set toGroupPagingCenteredfor both horizontal and vertical orientations. This behavior is designed for horizontal scrolling, which is why it only worked correctly for horizontal orientation.Description of Change
UICollectionLayoutSectionOrthogonalScrollingBehavior.None. This disables orthogonal scrolling, which is correct for vertical scrolling because we don't want horizontal paging in this case.Issues Fixed
Fixes #27241
Tested the behaviour in the following platforms
Screenshot
CarouselViewIssue.mov
CarouselViewFixed.mov