Skip to content

[Windows] Fix for issues caused by setting Shell.FlyoutWidth on WinUI when binding context values are changed #27151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 26, 2025
Merged

[Windows] Fix for issues caused by setting Shell.FlyoutWidth on WinUI when binding context values are changed #27151

merged 9 commits into from
Feb 26, 2025

Conversation

Tamilarasan-Paranthaman
Copy link
Contributor

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman commented Jan 15, 2025 •
edited
Loading

Root Cause of the issue

  • The base.ArrangeOverride was not being called, which caused layout inconsistencies, such as disappearing text during runtime updates or pressing the Alt key. This occurred because the internal arrangement logic provided by the base implementation was skipped, leading to incomplete layout updates.

Description of Change

  • Added a call to base.ArrangeOverride(finalSize) to ensure that the internal layout logic provided by the base class is executed before applying custom arrangement logic. Updated the ArrangeOverride implementation to handle both the base arrangement and the custom layout logic for the _content element effectively. Ensured that the method consistently returns finalSize to confirm that the allocated size has been fully used, maintaining alignment with the layout system.

Issues Fixed

Fixes #19496
Fixes #23214
Fixes #15827

Tested the behaviour in the following platforms

  • Windows
  • Android
  • iOS
  • Mac

Screenshot

Before Issue Fix After Issue Fix
Before-Fix-FL-Width.mp4
After-Fix-FL-Width.mp4

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Jan 15, 2025
@karthikraja-arumugam karthikraja-arumugam added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jan 15, 2025
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@Tamilarasan-Paranthaman Tamilarasan-Paranthaman marked this pull request as ready for review January 16, 2025 15:07
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman requested a review from a team as a code owner January 16, 2025 15:07
@Tamilarasan-Paranthaman Tamilarasan-Paranthaman mentioned this pull request Jan 17, 2025
Merged
4 tasks
@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen
PureWeen previously requested changes Jan 30, 2025
View reviewed changes
Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Tamilarasan-Paranthaman can you rebase and fix conflicts?

@Tamilarasan-Paranthaman
Copy link
Contributor Author

@Tamilarasan-Paranthaman can you rebase and fix conflicts?

@PureWeen, conflicts have been resolved

@jsuarezruiz
Copy link
Contributor

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@devanathan-vaithiyanathan devanathan-vaithiyanathan mentioned this pull request Feb 12, 2025
Open
4 tasks
@PureWeen PureWeen dismissed their stale review February 26, 2025 21:33
  • changes applied
@PureWeen
Copy link
Member

  • failing test unrelated

@PureWeen PureWeen merged commit a598a40 into dotnet:main Feb 26, 2025
122 of 124 checks passed
tj-devel709 pushed a commit that referenced this pull request Mar 3, 2025
@Tamilarasan-Paranthaman @tj-devel709
[Windows] Fix for issues caused by setting Shell.FlyoutWidth on WinUI…
50a8a83 
… when binding context values are changed (#27151)

* Fixed FlyoutItem issue

* Fixed Flyout Issues.

* Added test case.

* Added snapshot for WinUI and Mac

* Revert changes
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsuarezruiz jsuarezruiz jsuarezruiz approved these changes

@PureWeen PureWeen PureWeen left review comments

@StephaneDelcroix StephaneDelcroix Awaiting requested review from StephaneDelcroix StephaneDelcroix is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

@jfversluis jfversluis Awaiting requested review from jfversluis jfversluis is a code owner automatically assigned from dotnet/dotnet-maui-reviewers

Assignees
No one assigned
Labels
community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration
Projects
None yet
Milestone
No milestone
4 participants
@Tamilarasan-Paranthaman @jsuarezruiz @PureWeen @karthikraja-arumugam