Skip to content

[macOS] Remove unused FilePicker.macos.cs #26743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2024

Conversation

MartyIX
Copy link
Contributor

@MartyIX MartyIX commented Dec 20, 2024

Description of Change

It appears as if the file is unused. I hope that CI might tell us if I'm doing something wrong or if the file is really unused.

Issues Fixed

Contributes to #15126 (relevant comment which mentions AppKit)

@MartyIX MartyIX requested a review from a team as a code owner December 20, 2024 09:10
Copy link
Contributor

Hey there @MartyIX! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed.

@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Dec 20, 2024
@jfversluis
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@MartyIX MartyIX added platform/macOS 🍏 macOS / Mac Catalyst area-controls-picker Picker labels Dec 20, 2024
@rmarinho
Copy link
Member

the build seems good, but not that I think I wonder if we don t have a test for macOS and thats why it works.

@MartyIX
Copy link
Contributor Author

MartyIX commented Dec 20, 2024

the build seems good, but not that I think I wonder if we don t have a test for macOS and thats why it works.

I tried to change the file contents to add some nonsense (not valid C# code) and tried to call dotnet build and it passed for me. That makes me think that the file is not used in any way. Perhaps the PR should add such nonsense, CI should be run.

@PureWeen
Copy link
Member

  • failing test unrelated

@PureWeen PureWeen merged commit b2153b7 into dotnet:main Dec 26, 2024
102 of 104 checks passed
@MartyIX MartyIX deleted the feature/2024-12-20-unused-file branch December 26, 2024 17:34
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-picker Picker community ✨ Community Contribution platform/macOS 🍏 macOS / Mac Catalyst
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants