Fix for CollectionView SelectedItem loses Background after opening and closing a Modal page #26694
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing and closing a Modal page
karthikraja-arumugam
added
the
partner/syncfusion
jfversluis
added
the
area-controls-collectionview
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Azure Pipelines successfully started running 3 pipeline(s). |
jsuarezruiz
approved these changes
Jan 10, 2025
rmarinho
approved these changes
Jan 15, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root Cause
The root cause of the issue is that, on iOS, the native property ClearsSelectionOnViewWillAppear is set to true by default. This causes the background color of selected item to reset when navigating back to the CollectionView after modal navigation.
Description of Change
The fix involves setting the ClearsSelectionOnViewWillAppear property to false in the UpdatePlatformSelectionMode method, which is triggered whenever the selection mode is updated. This ensures that the fix is dynamically applied and maintains the selection state across modal navigation, regardless of runtime changes to the selection mode.
Additionally, this issue was identified in CollectionViewHandler2 as well. The same fix was applied to SelectableItemsViewController2 and validated to ensure consistent behavior across both versions of the CollectionView.
Tested the behaviour in the following platforms
Issues Fixed
Fixes #22467
Screenshots
WithoutFix.mov
WithFix.mov