[iOS] Set height for EmptyView if is not an IView #26680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmarinho
added
area-controls-collectionview
There was a problem hiding this comment.
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25551.cs:11
- The namespace was changed from 'Microsoft.Maui.TestCases.Tests.Tests.Issues' to 'Microsoft.Maui.TestCases.Tests.Issues'. Verify if this change aligns with the project's namespace conventions.
namespace Microsoft.Maui.TestCases.Tests.Issues
PureWeen
approved these changes
Dec 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
We introduced some calculations for when EmptyView is a IView, but the user can just provide a string as the EmptyView and that will be rendered as UILabel on iOS.
By setting by default the CollectionView.Height we keep the old behaviour.
Issues Fixed
Fixes #26663