[X] Avoid unnecessary steps #26671
Merged
[X] Avoid unnecessary steps #26671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
those IValueProviders are returning this, and doing nothing. Removing the interface will avoid unnecessary handling and invocation This is technically a breaking change, but - it shouldn't affect already compiled XAML - it shouldn't affect non-compiled XAML either
jsuarezruiz
approved these changes
Jan 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
[X] Avoid unnecessary steps
those IValueProviders are returning this, and doing nothing. Removing the interface will avoid unnecessary handling and invocation
This is technically a breaking change, but
Issues Fixed
Fixes #