Fix for CarouselView doesnot scroll corresponding to ItemsUpdatingScrollMode when collection modified #26608

SuthiYuvaraj · 2024-12-13T09:33:18Z

Issue Details

Behavior in windows: When modifying the collection, the CarouselView scrolls to display the first item. This is the expected behavior when considering the ItemsUpdatingScrollMode.
Android and iOS: While updating the collection, ItemsUpdatingScrollMode is not respected, causing the current position to deviate from the expected behavior for keeping items in view.

Root Cause

Android: In the MauiCarouselRecyclerView, the ItemsUpdatingScrollMode is not applied during the ItemsCollectionChanged event. As a result, the CarouselView maintains the position of the previously scrolled item.
iOS and Mac: In the CarouselViewController, the collection update ignores the ItemsUpdatingScrollMode, and the current position remains unchanged, irrespective of the scroll mode settings.

Fix Details

Android: Updated the MauiCarouselRecyclerView to adjust the carousel position based on the ItemsUpdatingScrollMode during collection updates.
iOS and Mac: Incorporated the ItemsUpdatingScrollMode into the collection update logic to ensure the position is updated appropriately according to the specified scroll mode.

Issues Fixed

Fixes #25991

Output Screenshot

Before Issue Fix	After Issue Fix
Screen.Recording.2024-12-12.at.8.33.19.PM.mov	Screen.Recording.2024-12-12.at.8.30.44.PM.mov

SuthiYuvaraj · 2024-12-13T11:31:05Z

Hi @jsuarezruiz, We have fixed the issue. On Windows, ItemsUpdatingScrollMode is considered during collection updates. For Android and iOS, we have implemented code changes to ensure consistent behavior across all platforms and test cases for this issue are already included in the 26160 PR

src/Controls/src/Core/Handlers/Items/iOS/CarouselViewController.cs

src/Controls/src/Core/Handlers/Items2/iOS/CarouselViewController2.cs

jfversluis · 2024-12-16T10:24:51Z

/azp run

azure-pipelines · 2024-12-16T10:25:14Z

Azure Pipelines successfully started running 3 pipeline(s).

rmarinho · 2024-12-18T15:02:39Z

/azp run

azure-pipelines · 2024-12-18T15:03:04Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

There are some CarouselView tests failing:

Issue12574Test

   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2107
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2124
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 651
   at Microsoft.Maui.TestCases.Tests.Issues.CarouselViewLoopNoFreeze.Issue12574Test() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/CarouselViewUITests.LoopNoFreeze.cs:line 44
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Issue10300Test

   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2107
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2124
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 651
   at Microsoft.Maui.TestCases.Tests.Issues.CarouselViewRemoveAt.Issue10300Test() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/CarouselViewUITests.RemoveAt.cs:line 25
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

SuthiYuvaraj · 2025-01-16T08:03:02Z

There are some CarouselView tests failing:

Issue12574Test

   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2107
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2124
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 651
   at Microsoft.Maui.TestCases.Tests.Issues.CarouselViewLoopNoFreeze.Issue12574Test() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/CarouselViewUITests.LoopNoFreeze.cs:line 44
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Issue10300Test

   at UITest.Appium.HelperExtensions.Wait(Func`1 query, Func`2 satisfactory, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2107
   at UITest.Appium.HelperExtensions.WaitForAtLeastOne(Func`1 query, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 2124
   at UITest.Appium.HelperExtensions.WaitForElement(IApp app, String marked, String timeoutMessage, Nullable`1 timeout, Nullable`1 retryFrequency, Nullable`1 postTimeout) in /_/src/TestUtils/src/UITest.Appium/HelperExtensions.cs:line 651
   at Microsoft.Maui.TestCases.Tests.Issues.CarouselViewRemoveAt.Issue10300Test() in /_/src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/CarouselViewUITests.RemoveAt.cs:line 25
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)

Hi @jsuarezruiz , The above-mentioned two issues are unrelated to our fix. Additionally, the timeout exception is not reproducible locally. Can we try re-running the tests once more?

jsuarezruiz

Could you include an UITest to validate all the values for the ItemsUpdatingScrollMode property?

using System.Collections.ObjectModel;

namespace Maui.Controls.Sample.Issues
{
	[Issue(IssueTracker.Github, 25991, "CarouselView reverts to displaying 1st item in collection when collection modified", PlatformAffected.UWP)]
	public class Issue25991 : ContentPage
	{
		public class Issue25991Model
		{
			public string Text { get; set; }
		}

		ObservableCollection<Issue25991Model> _collection = new ObservableCollection<Issue25991Model>()
		{
			new Issue25991Model() { Text = "Item 1" },
			new Issue25991Model() { Text = "Item 2" }
		};

		Label InfoLabel { get; set; }
		CarouselView TestCarouselView { get; set; }

		public Issue25991()
		{
			StackLayout mainStackLayout = new StackLayout();
			mainStackLayout.Margin = new Thickness(5);

			Label labelInstructions = new Label()
			{
				AutomationId = "WaitForStubControl",
				Text = "Instructions:\nThe CarouselView contains Item 1 and Item 2. It will initially show the first page, Item 1.\n" +
				"Click the 'Scroll to Item 2' button, and the CarouselView will correctly show Item 2.\n" +
				"Click 'Add Item', which will add a new Item record to the collection.\n" +
				"The CarouselView must stay in the Item 2."
			};
			mainStackLayout.Add(labelInstructions);

			InfoLabel = new Label()
			{
				AutomationId = "InfoLabel",
			};

			mainStackLayout.Add(InfoLabel);

			TestCarouselView = new CarouselView()
			{
				ItemsUpdatingScrollMode = ItemsUpdatingScrollMode.KeepScrollOffset,
				ItemsSource = _collection,
				Loop = false
			};

			TestCarouselView.ItemTemplate = new DataTemplate(() =>
			{
				StackLayout stackLayout = new StackLayout();
				Label nameLabel = new Label();
				nameLabel.SetBinding(Label.TextProperty, "Text");
				nameLabel.FontSize = 25;
				nameLabel.TextColor = Colors.Red;
				stackLayout.Children.Add(nameLabel);
				return stackLayout;
			});

			TestCarouselView.CurrentItemChanged += OnTestCarouselViewCurrentItemChanged;
			mainStackLayout.Add(TestCarouselView);

			Button scrollToPerson2Button = new Button()
			{
				AutomationId = "ScrollToPerson2Button",
				Text = "Scroll to Item 2"
			};
			scrollToPerson2Button.Clicked += OnScrollToPerson2ButtonClicked;
			mainStackLayout.Add(scrollToPerson2Button);

			Button addItemButton = new Button()
			{
				AutomationId = "AddItemButton",
				Text = "Add Item",
			};
			addItemButton.Clicked += OnAddButtonClicked;
			mainStackLayout.Add(addItemButton);


			HorizontalStackLayout buttonsStackLayout = new HorizontalStackLayout();
			Button keepItemsInViewButton = new Button()
			{
				AutomationId = "KeepItemsInViewButton",
				Text = "keepItemsInView",
			};
			keepItemsInViewButton.Clicked += OnKeepItemsInViewButtonClicked;
			buttonsStackLayout.Add(keepItemsInViewButton);
			Button keepScrollOffsetButton = new Button()
			{
				AutomationId = "KeepScrollOffsetButton",
				Text = "KeepScrollOffset",
			};
			keepScrollOffsetButton.Clicked += OnKeepScrollOffsetButtonClicked;
			buttonsStackLayout.Add(keepScrollOffsetButton);
			Button keepLastItemInViewButton = new Button()
			{
				AutomationId = "KeepLastItemInViewButton",
				Text = "KeepLastItemInView",
			};
			keepLastItemInViewButton.Clicked += OnKeepLastItemInViewButtonClicked;
			buttonsStackLayout.Add(keepLastItemInViewButton);
			mainStackLayout.Add(buttonsStackLayout);

			Content = mainStackLayout;
		}

		void OnTestCarouselViewCurrentItemChanged(object sender, CurrentItemChangedEventArgs e)
		{
			InfoLabel.Text = TestCarouselView.Position.ToString();
		}

		void OnScrollToPerson2ButtonClicked(object sender, EventArgs e)
		{
			TestCarouselView.ScrollTo(1);
		}

		void OnAddButtonClicked(object sender, EventArgs e)
		{
			_collection.Add(new Issue25991Model()
			{
				Text = "Item " + (_collection.Count + 1),
			});
		}

		void OnKeepItemsInViewButtonClicked(object sender, EventArgs e)
		{
			TestCarouselView.ItemsUpdatingScrollMode = ItemsUpdatingScrollMode.KeepItemsInView;
		}

		void OnKeepScrollOffsetButtonClicked(object sender, EventArgs e)
		{
			TestCarouselView.ItemsUpdatingScrollMode = ItemsUpdatingScrollMode.KeepScrollOffset;
		}

		void OnKeepLastItemInViewButtonClicked(object sender, EventArgs e)
		{
			TestCarouselView.ItemsUpdatingScrollMode = ItemsUpdatingScrollMode.KeepLastItemInView;
		}
	}
}

SuthiYuvaraj · 2025-02-03T11:37:01Z

Could you include an UITest to validate all the values for the ItemsUpdatingScrollMode property?

using System.Collections.ObjectModel;

namespace Maui.Controls.Sample.Issues
{
	[Issue(IssueTracker.Github, 25991, "CarouselView reverts to displaying 1st item in collection when collection modified", PlatformAffected.UWP)]
	public class Issue25991 : ContentPage
	{
		public class Issue25991Model
		{
			public string Text { get; set; }
		}

		ObservableCollection<Issue25991Model> _collection = new ObservableCollection<Issue25991Model>()
		{
			new Issue25991Model() { Text = "Item 1" },
			new Issue25991Model() { Text = "Item 2" }
		};

		Label InfoLabel { get; set; }
		CarouselView TestCarouselView { get; set; }

		public Issue25991()
		{
			StackLayout mainStackLayout = new StackLayout();
			mainStackLayout.Margin = new Thickness(5);

			Label labelInstructions = new Label()
			{
				AutomationId = "WaitForStubControl",
				Text = "Instructions:\nThe CarouselView contains Item 1 and Item 2. It will initially show the first page, Item 1.\n" +
				"Click the 'Scroll to Item 2' button, and the CarouselView will correctly show Item 2.\n" +
				"Click 'Add Item', which will add a new Item record to the collection.\n" +
				"The CarouselView must stay in the Item 2."
			};
			mainStackLayout.Add(labelInstructions);

			InfoLabel = new Label()
			{
				AutomationId = "InfoLabel",
			};

			mainStackLayout.Add(InfoLabel);

			TestCarouselView = new CarouselView()
			{
				ItemsUpdatingScrollMode = ItemsUpdatingScrollMode.KeepScrollOffset,
				ItemsSource = _collection,
				Loop = false
			};

			TestCarouselView.ItemTemplate = new DataTemplate(() =>
			{
				StackLayout stackLayout = new StackLayout();
				Label nameLabel = new Label();
				nameLabel.SetBinding(Label.TextProperty, "Text");
				nameLabel.FontSize = 25;
				nameLabel.TextColor = Colors.Red;
				stackLayout.Children.Add(nameLabel);
				return stackLayout;
			});

			TestCarouselView.CurrentItemChanged += OnTestCarouselViewCurrentItemChanged;
			mainStackLayout.Add(TestCarouselView);

			Button scrollToPerson2Button = new Button()
			{
				AutomationId = "ScrollToPerson2Button",
				Text = "Scroll to Item 2"
			};
			scrollToPerson2Button.Clicked += OnScrollToPerson2ButtonClicked;
			mainStackLayout.Add(scrollToPerson2Button);

			Button addItemButton = new Button()
			{
				AutomationId = "AddItemButton",
				Text = "Add Item",
			};
			addItemButton.Clicked += OnAddButtonClicked;
			mainStackLayout.Add(addItemButton);


			HorizontalStackLayout buttonsStackLayout = new HorizontalStackLayout();
			Button keepItemsInViewButton = new Button()
			{
				AutomationId = "KeepItemsInViewButton",
				Text = "keepItemsInView",
			};
			keepItemsInViewButton.Clicked += OnKeepItemsInViewButtonClicked;
			buttonsStackLayout.Add(keepItemsInViewButton);
			Button keepScrollOffsetButton = new Button()
			{
				AutomationId = "KeepScrollOffsetButton",
				Text = "KeepScrollOffset",
			};
			keepScrollOffsetButton.Clicked += OnKeepScrollOffsetButtonClicked;
			buttonsStackLayout.Add(keepScrollOffsetButton);
			Button keepLastItemInViewButton = new Button()
			{
				AutomationId = "KeepLastItemInViewButton",
				Text = "KeepLastItemInView",
			};
			keepLastItemInViewButton.Clicked += OnKeepLastItemInViewButtonClicked;
			buttonsStackLayout.Add(keepLastItemInViewButton);
			mainStackLayout.Add(buttonsStackLayout);

			Content = mainStackLayout;
		}

		void OnTestCarouselViewCurrentItemChanged(object sender, CurrentItemChangedEventArgs e)
		{
			InfoLabel.Text = TestCarouselView.Position.ToString();
		}

		void OnScrollToPerson2ButtonClicked(object sender, EventArgs e)
		{
			TestCarouselView.ScrollTo(1);
		}

		void OnAddButtonClicked(object sender, EventArgs e)
		{
			_collection.Add(new Issue25991Model()
			{
				Text = "Item " + (_collection.Count + 1),
			});
		}

		void OnKeepItemsInViewButtonClicked(object sender, EventArgs e)
		{
			TestCarouselView.ItemsUpdatingScrollMode = ItemsUpdatingScrollMode.KeepItemsInView;
		}

		void OnKeepScrollOffsetButtonClicked(object sender, EventArgs e)
		{
			TestCarouselView.ItemsUpdatingScrollMode = ItemsUpdatingScrollMode.KeepScrollOffset;
		}

		void OnKeepLastItemInViewButtonClicked(object sender, EventArgs e)
		{
			TestCarouselView.ItemsUpdatingScrollMode = ItemsUpdatingScrollMode.KeepLastItemInView;
		}
	}
}

Hi @jsuarezruiz ,We have added the UITest cases to validate all the values for the ItemsUpdatingScrollMode property. Let us know if any further modifications are needed.

jsuarezruiz · 2025-02-05T15:29:35Z

/azp run

azure-pipelines · 2025-02-05T15:29:55Z

Azure Pipelines successfully started running 3 pipeline(s).

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25991.cs

src/Controls/src/Core/Handlers/Items/iOS/CarouselViewController.cs

rmarinho · 2025-02-22T16:11:09Z

/rebase

jsuarezruiz · 2025-03-04T12:52:57Z

/rebase

src/Controls/src/Core/Handlers/Items/Android/MauiCarouselRecyclerView.cs

jsuarezruiz · 2025-03-18T12:54:40Z

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/XFIssue/Issue8964.cs

@@ -1,4 +1,5 @@
-#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_WINDOWS && TEST_FAILS_ON_ANDROID //The Position property now functions correctly on Android and Windows, issue: https://github.com/dotnet/maui/issues/15443. Note that on Catalyst, swipe and drag options are not supported in Appium.
+#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_WINDOWS && TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_IOS //The Position property now functions correctly on Android and Windows, issue: https://github.com/dotnet/maui/issues/15443. Note that on Catalyst, swipe and drag options are not supported in Appium.


Now, on Catalyst, the Appium drag actions should be supported. However, probably you will get the same result than on iOS. But, to avoid future confusion, could update the comment?

I have modified the comments; kindly review the changes and let me know if you have any concerns.

rmarinho · 2025-03-18T17:50:35Z

/azp run

azure-pipelines · 2025-03-18T17:50:59Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

I am going to re-run the Windows UITests. The test CarouselViewPositionFromVisibilityChangeTest is failing and seems that could be related with the changes.

jsuarezruiz · 2025-03-20T09:31:06Z

/azp run

azure-pipelines · 2025-03-20T09:31:29Z

Azure Pipelines successfully started running 3 pipeline(s).

jsuarezruiz

Ok, It's ok for the Flight branch

…ollMode when collection modified (dotnet#26608) * Added sample * Added test * Added UITest to validate Windows CarouselView scrolling behavior * Updated test * Updated test * More changes * Commit for 25991 * Commit for testcase changes * Update CarouselViewController2.cs * commit for unwanted changes * commit for unwanted changes * commit for testcase removal * commit for refactor * commit for method name change * Added sample * Added test * Added UITest to validate Windows CarouselView scrolling behavior * Updated test * Updated test * More changes * Fix the test * Update Issue25991.cs with minor fixes and additions * Fix Issue25991 test assertions and string format * Commit for testcase failure * commit for testcase changes * commit for testcase changes * Create ItemShouldbeScrolledbasedOnGroupHeader.png * Delete ItemShouldbeScrolledbasedOnGroupHeader.png * Add check for empty ItemsSource in CarouselViewController2. * Fix item addition logic in Issue25991 test * Update issue comments in Issue8964.cs --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>

…ollMode when collection modified (#26608) * Added sample * Added test * Added UITest to validate Windows CarouselView scrolling behavior * Updated test * Updated test * More changes * Commit for 25991 * Commit for testcase changes * Update CarouselViewController2.cs * commit for unwanted changes * commit for unwanted changes * commit for testcase removal * commit for refactor * commit for method name change * Added sample * Added test * Added UITest to validate Windows CarouselView scrolling behavior * Updated test * Updated test * More changes * Fix the test * Update Issue25991.cs with minor fixes and additions * Fix Issue25991 test assertions and string format * Commit for testcase failure * commit for testcase changes * commit for testcase changes * Create ItemShouldbeScrolledbasedOnGroupHeader.png * Delete ItemShouldbeScrolledbasedOnGroupHeader.png * Add check for empty ItemsSource in CarouselViewController2. * Fix item addition logic in Issue25991 test * Update issue comments in Issue8964.cs --------- Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>

dotnet-policy-service bot added the community ✨ Community Contribution label Dec 13, 2024

vishnumenon2684 added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Dec 13, 2024

jfversluis added the area-controls-collectionview CollectionView, CarouselView, IndicatorView label Dec 13, 2024

SuthiYuvaraj marked this pull request as ready for review December 13, 2024 15:22

SuthiYuvaraj requested a review from a team as a code owner December 13, 2024 15:22

SuthiYuvaraj requested review from StephaneDelcroix and mattleibow December 13, 2024 15:22

rmarinho reviewed Dec 13, 2024

View reviewed changes

src/Controls/src/Core/Handlers/Items/iOS/CarouselViewController.cs Show resolved Hide resolved

rmarinho reviewed Dec 13, 2024

View reviewed changes

src/Controls/src/Core/Handlers/Items2/iOS/CarouselViewController2.cs Outdated Show resolved Hide resolved

SuthiYuvaraj changed the title ~~Fix for CarouselView reverts to displaying 1st item in collection when collection modified~~ Fix for CarouselView doesnot scroll corresponding to ItemsUpdatingScrollMode when collection modified Dec 18, 2024

jsuarezruiz requested changes Jan 14, 2025

View reviewed changes

PureWeen added this to the .NET 9 SR5 milestone Jan 28, 2025

jsuarezruiz requested changes Jan 30, 2025

View reviewed changes

jsuarezruiz mentioned this pull request Jan 30, 2025

[Testing] Added tests to validate the ItemsUpdatingScrollMode property in CarouselView #26160

Closed

jsuarezruiz requested changes Feb 6, 2025

View reviewed changes

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue25991.cs Show resolved Hide resolved

src/Controls/src/Core/Handlers/Items/iOS/CarouselViewController.cs Show resolved Hide resolved

dotnet deleted a comment from azure-pipelines bot Feb 22, 2025

dotnet deleted a comment from jsuarezruiz Feb 22, 2025

github-actions bot force-pushed the fix-25991 branch from f6a1d23 to 5594050 Compare February 22, 2025 16:11

PureWeen moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Mar 2, 2025

SuthiYuvaraj and others added 7 commits March 18, 2025 12:19

Commit for testcase failure

d740580

commit for testcase changes

c4ff542

commit for testcase changes

332f41d

Create ItemShouldbeScrolledbasedOnGroupHeader.png

0f16181

Delete ItemShouldbeScrolledbasedOnGroupHeader.png

00b9472

Add check for empty ItemsSource in CarouselViewController2.

3b4646d

Fix item addition logic in Issue25991 test

a3d49a5

github-actions bot force-pushed the fix-25991 branch from 48a51ec to a3d49a5 Compare March 18, 2025 12:19

jsuarezruiz reviewed Mar 18, 2025

View reviewed changes

PureWeen moved this from Changes Requested to Ready To Review in MAUI SDK Ongoing Mar 18, 2025

rmarinho previously approved these changes Mar 18, 2025

View reviewed changes

jsuarezruiz reviewed Mar 19, 2025

View reviewed changes

Update issue comments in Issue8964.cs

cf47ba8

SuthiYuvaraj dismissed rmarinho’s stale review via cf47ba8 March 19, 2025 17:29

rmarinho changed the base branch from main to inflight/current March 20, 2025 11:00

rmarinho approved these changes Mar 20, 2025

View reviewed changes

jsuarezruiz approved these changes Mar 20, 2025

View reviewed changes

github-project-automation bot moved this from Ready To Review to Approved in MAUI SDK Ongoing Mar 20, 2025

rmarinho merged commit ba04b4e into dotnet:inflight/current Mar 20, 2025
66 of 74 checks passed

github-project-automation bot moved this from Approved to Done in MAUI SDK Ongoing Mar 20, 2025

github-actions bot locked and limited conversation to collaborators Apr 20, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix for CarouselView doesnot scroll corresponding to ItemsUpdatingScrollMode when collection modified #26608

Fix for CarouselView doesnot scroll corresponding to ItemsUpdatingScrollMode when collection modified #26608

SuthiYuvaraj commented Dec 13, 2024

SuthiYuvaraj commented Dec 13, 2024

jfversluis commented Dec 16, 2024

azure-pipelines bot commented Dec 16, 2024

rmarinho commented Dec 18, 2024

azure-pipelines bot commented Dec 18, 2024

jsuarezruiz left a comment

SuthiYuvaraj commented Jan 16, 2025

jsuarezruiz left a comment

SuthiYuvaraj commented Feb 3, 2025

jsuarezruiz commented Feb 5, 2025

azure-pipelines bot commented Feb 5, 2025

rmarinho commented Feb 22, 2025

jsuarezruiz commented Mar 4, 2025

jsuarezruiz Mar 18, 2025

SuthiYuvaraj Mar 19, 2025

rmarinho commented Mar 18, 2025

azure-pipelines bot commented Mar 18, 2025

jsuarezruiz left a comment

jsuarezruiz commented Mar 20, 2025

azure-pipelines bot commented Mar 20, 2025

jsuarezruiz left a comment

		@@ -1,4 +1,5 @@
		#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_WINDOWS && TEST_FAILS_ON_ANDROID //The Position property now functions correctly on Android and Windows, issue: https://github.com/dotnet/maui/issues/15443. Note that on Catalyst, swipe and drag options are not supported in Appium.
		#if TEST_FAILS_ON_CATALYST && TEST_FAILS_ON_WINDOWS && TEST_FAILS_ON_ANDROID && TEST_FAILS_ON_IOS //The Position property now functions correctly on Android and Windows, issue: https://github.com/dotnet/maui/issues/15443. Note that on Catalyst, swipe and drag options are not supported in Appium.

Fix for CarouselView doesnot scroll corresponding to ItemsUpdatingScrollMode when collection modified #26608

Fix for CarouselView doesnot scroll corresponding to ItemsUpdatingScrollMode when collection modified #26608

Conversation

SuthiYuvaraj commented Dec 13, 2024

Issue Details

Root Cause

Fix Details

Issues Fixed

Output Screenshot

SuthiYuvaraj commented Dec 13, 2024

jfversluis commented Dec 16, 2024

azure-pipelines bot commented Dec 16, 2024

rmarinho commented Dec 18, 2024

azure-pipelines bot commented Dec 18, 2024

jsuarezruiz left a comment

Choose a reason for hiding this comment

SuthiYuvaraj commented Jan 16, 2025

jsuarezruiz left a comment

Choose a reason for hiding this comment

SuthiYuvaraj commented Feb 3, 2025

jsuarezruiz commented Feb 5, 2025

azure-pipelines bot commented Feb 5, 2025

rmarinho commented Feb 22, 2025

jsuarezruiz commented Mar 4, 2025

jsuarezruiz Mar 18, 2025

Choose a reason for hiding this comment

SuthiYuvaraj Mar 19, 2025

Choose a reason for hiding this comment

rmarinho commented Mar 18, 2025

azure-pipelines bot commented Mar 18, 2025

jsuarezruiz left a comment

Choose a reason for hiding this comment

jsuarezruiz commented Mar 20, 2025

azure-pipelines bot commented Mar 20, 2025

jsuarezruiz left a comment

Choose a reason for hiding this comment