-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[iOS] Fix for CollectionView with horizontal grid layout has extra space on right end #25825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hey there @Tamilarasan-Paranthaman! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
@@ -0,0 +1,26 @@ | |||
#if !MACCATALYST || !WINDOWS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VerifyScreenshot is not implemented on Catalyst yet. Should not be necessary to avoid in that platform.
Why avoid it on Windows?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz, It seems that item spacing on the Windows platform is still not functioning correctly, so I am skipping the Windows platform for now. For your reference, I have attached the related issue report #11320. How can we proceed with this? Please share your thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you include a comment in code with a reference to the issue #11320?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuarezruiz, I have added a comment. Could you please check and provide your concerns if any?
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Root Cause of the issue
HorizontalItemSpacing
was being applied from theGetInsetForSection
method, even though it was not a grouped collectionDescription of Change
Note
HorizontalOptions
set to center, as it seems the collection view occupies the entire width in CV2. For now, I have used CollectionView1 in the test sample since I have fixed the issue in CollectionView1.maui/src/Controls/tests/TestCases.HostApp/Issues/Issue25433.xaml
Line 8 in d0d9a53
Issues Fixed
Fixes #25433
Tested the behaviour in the following platforms
Screenshot
1. Without Grouping:
2. With Grouping