Skip to content

[Android] Added a scroll bar for collection view #25471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Oct 23, 2024

Issues Fixed

Fixes #25468
Fixes #11369

Before After
Screen.Recording.2024-10-23.at.14.36.42.mov
Screen.Recording.2024-10-23.at.14.07.21.mov

@kubaflo kubaflo requested a review from a team as a code owner October 23, 2024 12:53
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Oct 23, 2024
@kubaflo kubaflo added platform/android 🤖 area-controls-collectionview CollectionView, CarouselView, IndicatorView labels Oct 23, 2024
@rmarinho

This comment was marked as outdated.

@rmarinho

This comment was marked as outdated.

This comment was marked as outdated.

@kubaflo kubaflo force-pushed the collection-view-scroll-bar branch from a185ccc to ab0870d Compare October 27, 2024 12:32
@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Nov 18, 2024

/azp run

This comment was marked as outdated.

@jfversluis

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the collection-view-scroll-bar branch from ab0870d to 86fde22 Compare December 9, 2024 14:46

This comment was marked as outdated.

@jfversluis

This comment was marked as outdated.

@github-actions github-actions bot force-pushed the collection-view-scroll-bar branch from 86fde22 to ccb1988 Compare December 12, 2024 12:46
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test fails :(

image

@kubaflo kubaflo force-pushed the collection-view-scroll-bar branch from ccb1988 to dc15c9c Compare December 16, 2024 12:24
@kubaflo
Copy link
Contributor Author

kubaflo commented Dec 16, 2024

@jfversluis hmmm it looks like there are the same problems with other tests too. Could you please /azp again?

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis added this to the .NET 9 SR3 milestone Dec 18, 2024
@jfversluis jfversluis merged commit 06cd04d into dotnet:main Dec 18, 2024
104 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-collectionview CollectionView, CarouselView, IndicatorView community ✨ Community Contribution platform/android 🤖
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Android] Collection view has no scroll bar CollectionView shows no ScrollBar
4 participants