Skip to content

[iOS] Using long-press navigation on back button with shell pages - fix #24003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

kubaflo
Copy link
Contributor

@kubaflo kubaflo commented Aug 4, 2024

Description of Change

The [Export("navigationBar:shouldPopItem:")] is not being triggered when navigating back with the iOS's callout menu

Fixes #23892

Before After
Screen.Recording.2024-08-04.at.17.30.36.mov
Screen.Recording.2024-08-04.at.17.42.42.mov

@kubaflo kubaflo requested a review from a team as a code owner August 4, 2024 15:54
@kubaflo kubaflo added platform/iOS 🍎 area-controls-shell Shell Navigation, Routes, Tabs, Flyout labels Aug 4, 2024
@kubaflo kubaflo marked this pull request as draft August 4, 2024 15:56
@dotnet-policy-service dotnet-policy-service bot added the community ✨ Community Contribution label Aug 4, 2024
@jsuarezruiz

This comment was marked as outdated.

This comment was marked as outdated.

@jsuarezruiz

This comment was marked as outdated.

@jsuarezruiz
Copy link
Contributor

jsuarezruiz commented Nov 12, 2024

/azp run

This comment was marked as outdated.

@kubaflo kubaflo marked this pull request as ready for review November 15, 2024 00:42
@kubaflo kubaflo changed the title [iOS] Using long-press navigation on back button - fix [iOS] Using long-press navigation on back button with shell pages - fix Nov 29, 2024

This comment was marked as outdated.

@jfversluis

This comment was marked as outdated.

This comment was marked as outdated.

Copy link
Member

@jfversluis jfversluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK after 5 retries I think something might actually be wrong here 😅

The error also seems somewhat relevant to what is changed here so I think we should look into it: "[FAIL] Back Button Behavior Text"

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Copy link
Member

@PureWeen PureWeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test?

The PR here uses a long press on the back button to simulator a long press on the back button

#25552

@kubaflo
Copy link
Contributor Author

kubaflo commented Jan 6, 2025

@PureWeen I've added a UITest LongPress() works :)

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@PureWeen
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@jfversluis jfversluis dismissed PureWeen’s stale review February 14, 2025 14:25

Feedback addressed

@jfversluis jfversluis added this to the .NET 9 SR5 milestone Feb 14, 2025
@jfversluis jfversluis merged commit 98f7e6a into dotnet:main Feb 14, 2025
123 checks passed
albyrock87 added a commit to nalu-development/maui-custom that referenced this pull request Feb 26, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution platform/iOS 🍎
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Using long-press navigation on back button using shell does not update the shell's current page
4 participants