-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[iOS] Using long-press navigation on back button with shell pages - fix #24003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
9a78edc
to
8f1e0a0
Compare
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
3a3929f
to
0d481e6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK after 5 retries I think something might actually be wrong here 😅
The error also seems somewhat relevant to what is changed here so I think we should look into it: "[FAIL] Back Button Behavior Text"
Azure Pipelines successfully started running 3 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test?
The PR here uses a long press on the back button to simulator a long press on the back button
@PureWeen I've added a UITest |
Azure Pipelines successfully started running 3 pipeline(s). |
Update ShellSectionRenderer.cs
/azp run |
Azure Pipelines successfully started running 3 pipeline(s). |
Description of Change
The
[Export("navigationBar:shouldPopItem:")]
is not being triggered when navigating back with the iOS's callout menuFixes #23892
Screen.Recording.2024-08-04.at.17.30.36.mov
Screen.Recording.2024-08-04.at.17.42.42.mov