-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add support for iOS/Mac specific modals styled as popovers #23984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@dotnet-policy-service agree |
Since this introduces new APIs can you please target this for .NET 9? The net9.0 branch? |
Sure, that's it done. There's a few conflicts now, mainly around the PublicAPI.Unshipped.txt files, but I'm not very familiar with these so unsure what the correct procedure is. |
@piersdeseilligny API tracking is described here: https://github.com/dotnet/maui/blob/main/docs/design/APIChangeTracking.md. If you add new APIs, then there should be new entries in CTRL+. in Visual Studio can add the missing entries to those text files for you. Not sure if VS Code can do the same. |
/azp run |
I rebased your PR, could you confirm the code still looks good? :) |
This comment was marked as outdated.
This comment was marked as outdated.
2 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
src/Controls/src/Core/Platform/ModalNavigationManager/ModalNavigationManager.iOS.cs
Outdated
Show resolved
Hide resolved
This comment was marked as off-topic.
This comment was marked as off-topic.
@piersdeseilligny Could you rebase and fix the conflicts? Let me know if need help in some way. |
@jsuarezruiz let me know if that's all looking ok now? Sorry I don't have a good grasp on these PublicAPI .txt files so i'm not entirely sure if i merged everything correctly. |
Can we rebase this on main please? |
Any chance this could make it into .NET 9 SR2? |
@jsuarezruiz @rmarinho We would also like to see this merged into MAUI. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as off-topic.
This comment was marked as off-topic.
259227a
to
02a4174
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Not to nag, but any update on when this may get merged? |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Successful build for .NET 10 is here: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10992030&view=results (includes the latest changes done after this comment) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this @piersdeseilligny, sorry it took a little while!
The good news is that we're merging this, the bad news is that it will be for .NET 10. So expect to see this pop up in the previews first. It's coming!
Description of Change
Fixes #23975 by adding support for the iOS/Mac specific feature of modals styled as Popovers.
This is achieved by simply adding
PlatformConfiguration.iOSSpecific.UIModalPresentationStyle.Popover
, which maps toUIKit.UIModalPresentationStyle.Popover
.In order to specify where the popover is originating from, this PR also adds support for the following:
On<iOS>().SetModalPopoverView(Microsoft.Maui.Controls.View);
On<iOS>().SetModalPopoverRect(System.Drawing.Rectangle);
Demo
Screen.Recording.2024-08-02.at.17.25.00.mov
Example Usage
Parent page:
Modal page: