Skip to content

[X] deprecate fontImageExtension #23657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 10, 2025
Merged

[X] deprecate fontImageExtension #23657

merged 3 commits into from
Feb 10, 2025

Conversation

StephaneDelcroix
Copy link
Contributor

Description of Change

The passthrough markup extensions serves no purposes, and isn't as flexible as the complete FontImageSource (allowing bindings, dynamicresources, ...)

For convenience, the element syntax can be used as a markup syntax {FontImagesource}

Issues Fixed

@StephaneDelcroix StephaneDelcroix requested a review from a team as a code owner July 17, 2024 16:02
@StephaneDelcroix StephaneDelcroix changed the title [X] deprecated fontImageExtension [X] deprecate fontImageExtension Jul 17, 2024
Copy link
Member

@rmarinho rmarinho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add REMOVE in the unpublished public api not removed them for the PublicAPI .
Also a change to remove something don t you think should be targeting net9 ?

@Eilon Eilon added the area-fonts Custom fonts and Font related API's label Jul 19, 2024
@StephaneDelcroix
Copy link
Contributor Author

@rmarinho fixed

@jfversluis jfversluis added this to the .NET 10 Planning milestone Jan 22, 2025
@rmarinho
Copy link
Member

rmarinho commented Feb 4, 2025

Please rebase on net10.0 branch

@rmarinho rmarinho changed the base branch from main to net10.0 February 4, 2025 10:54
@StephaneDelcroix
Copy link
Contributor Author

Please rebase on net10.0 branch

done

@samhouts samhouts requested a review from rmarinho February 6, 2025 21:53
@jfversluis

This comment was marked as off-topic.

@jfversluis

This comment was marked as off-topic.

This comment was marked as outdated.

@jfversluis
Copy link
Member

jfversluis commented Feb 9, 2025

/azp run

This comment was marked as outdated.

1 similar comment

This comment was marked as off-topic.

StephaneDelcroix and others added 3 commits February 10, 2025 14:36
The passthrough markup extensions serves no purposes, and isn't as
flexible as the complete FontImageSource (allowing bindings,
dynamicresources, ...)

For convenience, the element syntax can be used as a markup syntax
{FontImagesource}

- fixes #23347
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jfversluis jfversluis removed this from the .NET 10 Planning milestone Feb 10, 2025
@jfversluis jfversluis added this to the .NET 10.0-preview2 milestone Feb 10, 2025
@jfversluis jfversluis dismissed rmarinho’s stale review February 10, 2025 16:48

Feedback addressed

Copy link
Contributor

🚨 API change(s) detected @davidbritch FYI

@jfversluis jfversluis merged commit 31a53c9 into net10.0 Feb 10, 2025
5 checks passed
@jfversluis jfversluis deleted the fix_23347 branch February 10, 2025 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-fonts Custom fonts and Font related API's t/breaking 💥
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FontImage markup extension doesn't allow AppThemeBinding
4 participants