-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[X] deprecate fontImageExtension #23657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add REMOVE in the unpublished public api not removed them for the PublicAPI .
Also a change to remove something don t you think should be targeting net9 ?
5b9ccd8
to
8b0761d
Compare
@rmarinho fixed |
Please rebase on net10.0 branch |
8b0761d
to
65ead01
Compare
done |
This comment was marked as off-topic.
This comment was marked as off-topic.
65ead01
to
88178f2
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as outdated.
This comment was marked as outdated.
/azp run |
This comment was marked as outdated.
This comment was marked as outdated.
1 similar comment
This comment was marked as off-topic.
This comment was marked as off-topic.
The passthrough markup extensions serves no purposes, and isn't as flexible as the complete FontImageSource (allowing bindings, dynamicresources, ...) For convenience, the element syntax can be used as a markup syntax {FontImagesource} - fixes #23347
11f4382
to
5648858
Compare
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
🚨 API change(s) detected @davidbritch FYI |
Description of Change
The passthrough markup extensions serves no purposes, and isn't as flexible as the complete FontImageSource (allowing bindings, dynamicresources, ...)
For convenience, the element syntax can be used as a markup syntax {FontImagesource}
Issues Fixed