Fix BindingAdapterPosition Exception (#22676)

* Fix BindingAdapterPosition Exception

* Added UITest

* Run the test in all the platforms

* Run the test in Android

* Add test category

---------

Co-authored-by: Javier Suárez <javiersuarezruiz@hotmail.com>
Co-authored-by: Gerald Versluis <gerald.versluis@microsoft.com>

Author: 3 people

src/Controls/src/Core/Handlers/Items/Android/Adapters/SelectableItemsViewAdapter.cs

@@ -123,7 +123,10 @@ bool PositionIsSelected(int position)
 
 		void SelectableClicked(object sender, int adapterPosition)
 		{
-			UpdateMauiSelection(adapterPosition);
+			if (adapterPosition >= 0 && adapterPosition < ItemsSource?.Count)
+			{
+				UpdateMauiSelection(adapterPosition);
+			}
 		}
 
 		void UpdateMauiSelection(int adapterPosition)

src/Controls/tests/TestCases.HostApp/Issues/Issue22674.xaml

@@ -0,0 +1,18 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<ContentPage xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
+             xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
+             x:Class="Maui.Controls.Sample.Issues.Issue22674">
+  <CollectionView 
+    AutomationId="TestCollectionView"
+    SelectionMode="Single"
+		ItemsSource="{Binding ItemList}"
+		SelectionChanged="OnCollectionViewSelectionChanged">
+    <CollectionView.ItemTemplate>
+      <DataTemplate>
+        <Label
+          Text="{Binding .}" 
+          HorizontalTextAlignment="Center" />
+      </DataTemplate>
+    </CollectionView.ItemTemplate>
+  </CollectionView>
+</ContentPage>

src/Controls/tests/TestCases.HostApp/Issues/Issue22674.xaml.cs

@@ -0,0 +1,28 @@
+using System.Collections.ObjectModel;
+using Microsoft.Maui.Controls;
+using Microsoft.Maui.Controls.Xaml;
+
+namespace Maui.Controls.Sample.Issues
+{
+	[XamlCompilation(XamlCompilationOptions.Compile)]
+	[Issue(IssueTracker.Github, 22674, "Crash when quickly clicking to delete item", PlatformAffected.iOS)]
+	public partial class Issue22674 : ContentPage
+	{
+		public Issue22674()
+		{
+			InitializeComponent();
+
+			BindingContext = this;
+		}
+
+		public ObservableCollection<string> ItemList { get; } = ["A", "B", "C", "D", "E", "F", "G", "H", "I",];
+		
+		void OnCollectionViewSelectionChanged(object sender, SelectionChangedEventArgs e)
+		{
+			if (sender is CollectionView view && view.SelectedItem is string item)
+			{
+				ItemList.Remove(item);
+			}
+		}
+	}
+}

src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue22674.cs

@@ -0,0 +1,28 @@
+#if ANDROID
+using NUnit.Framework;
+using UITest.Appium;
+using UITest.Core;
+
+namespace Microsoft.Maui.TestCases.Tests.Issues;
+
+public class Issue22674 : _IssuesUITest
+{
+	public Issue22674(TestDevice device) : base(device) { }
+
+	public override string Issue => "Crash when quickly clicking to delete item";
+
+	[Test]
+	[Category(UITestCategories.CollectionView)]
+	public void RemoveItemWhenSelectionChanged()
+	{
+		App.WaitForElement("TestCollectionView");
+
+		for (int i = 0; i < 5; i++)
+		{
+			App.TapCoordinates(24, 24);
+		}
+
+		// Without crashes, the test has passed.
+	}
+}
+#endif