Guidance for AggressiveInlining and AggressiveOptimization (#9188)

* wording

* typo

* Apply suggestions from code review

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

---------

Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>

Author: danmoseley

xml/System.Runtime.CompilerServices/MethodImplOptions.xml

@@ -116,7 +116,10 @@
       </ReturnValue>
       <MemberValue>256</MemberValue>
       <Docs>
-        <summary>The method should be inlined if possible.</summary>
+        <summary>
+          <para>The method should be inlined if possible.</para>
+          <para>Unnecessary use of this attribute can reduce performance. The attribute might cause implementation limits to be encountered that will result in slower generated code. Always measure performance to ensure it's helpful to apply this attribute.</para>
+        </summary>
       </Docs>
     </Member>
     <Member MemberName="AggressiveOptimization">
@@ -148,9 +151,8 @@
       <MemberValue>512</MemberValue>
       <Docs>
         <summary>
-          <para>The method contains code that should always be optimized by the just-in-time (JIT) compiler.</para>
-          <para>Use this attribute if running an unoptimized version of the method has undesirable effects, for instance causing too much overhead or extra memory allocation.</para>
-          <para>Methods with this attribute may not have optimal code generation. They bypass the first tier of <a href="/dotnet/core/runtime-config/compilation#tiered-compilation">Tiered Compilation</a> and therefore can't benefit from optimizations that rely on tiering, for example, <a href="/dotnet/core/runtime-config/compilation#profile-guided-optimization">Dynamic PGO</a> or optimizations based on initialized classes.</para>
+          <para>The method contains code that should always be optimized for performance.</para>
+          <para>It's rarely appropriate to use this attribute. Methods that apply this attribute bypass the first tier of <a href="/dotnet/core/runtime-config/compilation#tiered-compilation">tiered compilation</a> and therefore don't benefit from optimizations that rely on tiered compilation. Those optimizations include <a href="/dotnet/core/runtime-config/compilation#profile-guided-optimization">dynamic PGO</a> and optimizations based on initialized classes. Use of this attribute might also increase memory use. Always measure performance to ensure it's helpful to apply this attribute.</para>
         </summary>
       </Docs>
     </Member>