Skip to content

[main] [release/10.0-preview1] Do not remove wixpacks from items to sign #60524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #60523 to main

/cc @wtgodbe @mmitche

[release/10.0-preview1] Do not remove wixpacks from items to sign

Summary of the changes (Less than 80 chars)

Description

{Detail}

Fixes #{bug number} (in this specific format)

Customer Impact

{Justification}

Regression?

  • Yes
  • No

[If yes, specify the version the behavior has regressed from]

Risk

  • High
  • Medium
  • Low

[Justify the selection above]

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

When servicing release/2.1

  • Make necessary changes in eng/PatchConfig.props

… so that they are identified as the pack for an msi or exe that can be unpacked, signed, and then used to re-create the msi/exe.
@github-actions github-actions bot requested review from wtgodbe and a team as code owners February 20, 2025 18:21
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Feb 20, 2025
@wtgodbe wtgodbe merged commit da297fb into main Feb 25, 2025
22 of 26 checks passed
@wtgodbe wtgodbe deleted the backport/pr-60523-to-main branch February 25, 2025 01:28
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview3 milestone Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants