Unquarantine Reset_BeforeResponse_Resets #39447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
What's the theory behind how we think #35401 fixed this test? Do we know what was throwing before? I gues it would have been nice if we verified It looks like #35401 dealing avoids a race when the client aborts the request while it's being handled by the server. But this test doesn't have the client abort at all. How can calling |
|
The PR fixes an issue with Abort which is called in the test via the Reset feature, I'll leave it to Chris to explain more since he implemented the fix. |
|
Ping |
halter73
approved these changes
Jan 14, 2022
amcasey
added
area-networking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quarantine issue #29126