-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Un-redact safe request/response headers in HttpLoggingMiddleware #36307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CC @blowdart - any concerns on these? |
Request: Response: |
Any concerns with |
What is a "safe" header. One that doesn't contain personal information? |
Nope, no concerns |
Yes |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/aspnetcore/actions/runs/1218231063 |
Fixes #36156 based on decisions made about safe headers for Yarp by @samsp-msft. Here's an example console log, from the SignalR SocialWeather sample: