Skip to content

Update gRPC version in template to 2.32.0-pre1 #25587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2020

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 3, 2020

This PR updates the gRPC template and interop tests to use 2.32.0-pre1 of Grpc.AspNetCore/Grpc.Net.Client.

2.32.0-pre1 is being published to NuGet.org non-publicly because it uses RC1 APIs. When RC1 is released then it will be made public.

2.32.0 (non-preview) should be released on NuGet.org in two weeks. .NET 5 GA will be updated to use it in the template.

@JamesNK JamesNK added the area-grpc Includes: GRPC wire-up, templates label Sep 3, 2020
@JamesNK JamesNK added this to the 5.0.0-rc2 milestone Sep 3, 2020
@JamesNK JamesNK requested a review from dougbu as a code owner September 3, 2020 21:45
@Pilchie Pilchie added the Servicing-approved Shiproom has approved the issue label Sep 3, 2020
@Pilchie
Copy link
Member

Pilchie commented Sep 3, 2020

Approved for .NET 5 RC2 pending CI Completion.

@JamesNK JamesNK force-pushed the jamesnk/grpcversion-2.32.0-pre1 branch 2 times, most recently from 47a639b to d6baefb Compare September 10, 2020 02:21
@JamesNK JamesNK force-pushed the jamesnk/grpcversion-2.32.0-pre1 branch from 29a835f to 3422e52 Compare September 10, 2020 23:33
@JamesNK JamesNK force-pushed the jamesnk/grpcversion-2.32.0-pre1 branch from 3422e52 to 5bd471e Compare September 11, 2020 04:15
@JunTaoLuo
Copy link
Contributor

Ah it turns out we need to install different runtime for macos and linux on helix for the grpc interop tests.

@JunTaoLuo JunTaoLuo force-pushed the jamesnk/grpcversion-2.32.0-pre1 branch from eeffeb3 to 563a623 Compare September 12, 2020 00:11
@JunTaoLuo
Copy link
Contributor

Tests are passing and it's been approved for RC2. Merging.

@JunTaoLuo JunTaoLuo merged commit 340ee72 into release/5.0-rc2 Sep 12, 2020
@JunTaoLuo JunTaoLuo deleted the jamesnk/grpcversion-2.32.0-pre1 branch September 12, 2020 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-grpc Includes: GRPC wire-up, templates Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants