Skip to content

Revert "Add gRPC interop tests" #20047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
1 commit merged into from
Mar 21, 2020
Merged

Revert "Add gRPC interop tests" #20047

1 commit merged into from
Mar 21, 2020

Conversation

Pilchie
Copy link
Member

@Pilchie Pilchie commented Mar 21, 2020

Reverts #17040 - was causing failures in signed and rolling builds

@Pilchie Pilchie requested review from JamesNK and JunTaoLuo March 21, 2020 04:02
@Pilchie Pilchie requested a review from dougbu as a code owner March 21, 2020 04:02
@Pilchie Pilchie requested a review from a team March 21, 2020 04:02
@ghost
Copy link

ghost commented Mar 21, 2020

Hello @Pilchie!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 60 minutes. No worries though, I will be back when the time is right! 😉

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 236dcd9 into master Mar 21, 2020
@ghost ghost deleted the revert-17040-jamesnk/interoptests branch March 21, 2020 06:04
JunTaoLuo pushed a commit that referenced this pull request Mar 23, 2020
Revert "Revert "Add gRPC interop tests (#17040)" (#20047)"
56bc18c 
This reverts commit 236dcd9.
JunTaoLuo pushed a commit that referenced this pull request Mar 23, 2020
Add gRPC interop tests (again) (#20069)
6912dda 
* Revert "Revert "Add gRPC interop tests (#17040)" (#20047)"

This reverts commit 236dcd9.

* Fix daily and quarantine Helix runs

* Cleanup
This was referenced Mar 23, 2020
Closed
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JamesNK JamesNK JamesNK approved these changes

@JunTaoLuo JunTaoLuo Awaiting requested review from JunTaoLuo

@dougbu dougbu Awaiting requested review from dougbu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pilchie @JamesNK