-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add gRPC interop tests to our PR test suite #11064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@JamesNK @JunTaoLuo I'm guessing this isn't happening for Preview 9 at this point? |
@JunTaoLuo You're the best out of the two of us to do this one. Do you think you'll have time for it in the next couple of weeks? |
@JamesNK started a mail thread about this, so assigning him. Moving to the 5.0.0-preview1 milestone as well. |
Reasons
2 is particularly important. HttpSys work is happening now and it takes a long time to get changes in Windows. If we need changes then we have to discover them now and tell the correct teams. The interop tests provide a cross-section of major functionality to double-check we're compatible. There are only about 20 tests, and they take about 10 seconds to run. HowRun interop client against interop server to execute tests. In the official gRPC interop test environment the client is called from the command line. I think for our CI build we should just have a single parameterized unit test that will start the server, and create an InteropClient instance which is passed arguments for each test. That should work for Kestrel, and maybe HttpSys. Will need to investigate what to do for IIS functional testing. The interop client and server are both small self-contained apps, and should rarely - if ever - change. We can just copy and paste them from grpc-dotnet into aspnetcore and make minor edits to them as needed (the grpc-dotnet versions themselves were copied from grpc/grpc). |
Reverted the change, so re-opening. |
This was re-added by #20069 |
Investigate adding gRPC interop tests. These should not be mandatory.
The text was updated successfully, but these errors were encountered: