Fix crashing InMemory.FunctionalTests (#59821)

BrennanConroy · web-flow · commit 151d09e729a5 · 2025-01-12T19:07:16.000-08:00
diff --git a/src/Servers/Kestrel/test/InMemory.FunctionalTests/TestTransport/InMemoryTransportConnection.cs b/src/Servers/Kestrel/test/InMemory.FunctionalTests/TestTransport/InMemoryTransportConnection.cs
@@ -63,13 +63,11 @@ public override void Abort(ConnectionAbortedException abortReason)
 
     public void OnClosed()
     {
-        if (_isClosed)
+        if (Interlocked.CompareExchange(ref _isClosed, true, false) == true)
         {
             return;
         }
 
-        _isClosed = true;
-
         ThreadPool.UnsafeQueueUserWorkItem(state =>
         {
             state._connectionClosedTokenSource.Cancel();

Original file line number	Diff line number	Diff line change
`@@ -63,13 +63,11 @@ public override void Abort(ConnectionAbortedException abortReason)`
`63`	`63`
`64`	`64`	`public void OnClosed()`
`65`	`65`	`{`
`66`		`- if (_isClosed)`
	`66`	`+ if (Interlocked.CompareExchange(ref _isClosed, true, false) == true)`
`67`	`67`	`{`
`68`	`68`	`return;`
`69`	`69`	`}`
`70`	`70`
`71`		`- _isClosed = true;`
`72`		`-`
`73`	`71`	`ThreadPool.UnsafeQueueUserWorkItem(state =>`
`74`	`72`	`{`
`75`	`73`	`state._connectionClosedTokenSource.Cancel();`