Skip to content

Ensure AzureProvisioningResource Outputs are populated correctly #8562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Apr 4, 2025

Description

This allows other code to inspect which Outputs a resource has.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
  • Did you add public API?
    • No
  • Does the change make any security assumptions or guarantees?
    • No
  • Does the change require an update in our Aspire docs?
    • No

This allows other code to inspect which Outputs a resource has.
@github-actions github-actions bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Apr 4, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

tests/Aspire.Hosting.Azure.Tests/AzureProvisioningResourceTests.cs:33

  • The test relies on the ordering of dictionary outputs, which may not be guaranteed. Consider using order-independent assertions (e.g. Assert.Contains or comparing collection keys) to verify all expected keys are present.
Assert.Collection(resource1.Resource.Outputs,

@eerhardt
Copy link
Member Author

eerhardt commented Apr 4, 2025

We might not need this. So making a draft for now, to discuss.

@eerhardt eerhardt marked this pull request as draft April 4, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant