Skip to content

[ci] Fail build if any untracked files written in git tree #9939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Mar 19, 2025

Context: #9661

Building on #9661, we also shouldn't be writing build artifacts to the source tree.

Any files generated by the build should be placed in /bin or /obj folders rather than the source tree.

Violations fixed by putting the artifact in .gitignore.

Current violations:

Mac:

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	src/native/CMakePresets.json

Linux:

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	src/native/CMakePresets.json
	src/native/clr/host/generate-pinvoke-tables
	src/native/clr/host/pinvoke-tables.include.generated
	src/native/mono/pinvoke-override/generate-pinvoke-tables
	src/native/mono/pinvoke-override/pinvoke-tables.include.generated

Windows

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	dotnet-install.ps1
	src/native/CMakePresets.json

@dotnet dotnet deleted a comment from azure-pipelines bot Apr 18, 2025
@jpobst jpobst force-pushed the dev/jpobst/dirty-tree branch 2 times, most recently from 4439559 to 862bd2b Compare April 18, 2025 21:40
@jpobst jpobst force-pushed the dev/jpobst/dirty-tree branch from 862bd2b to 6fc2a70 Compare April 18, 2025 22:27
@jpobst jpobst marked this pull request as ready for review April 19, 2025 01:12
@jpobst jpobst requested a review from grendello April 19, 2025 01:13
src/native/CMakePresets.json
src/native/clr/host/generate-pinvoke-tables
src/native/clr/host/pinvoke-tables.include.generated
src/native/mono/pinvoke-override/generate-pinvoke-tables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@grendello: is it safe to ignore changes to these files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, perfectly safe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants