Fix out-of-bounds address_v4::broadcast() return value on 64-bit systems.

chris_kohlhoff · chris_kohlhoff · commit 05e188508ae8 · 2011-01-13T09:07:56.000Z
diff --git a/asio/include/asio/ip/impl/address_v4.ipp b/asio/include/asio/ip/impl/address_v4.ipp
@@ -140,7 +140,7 @@ bool address_v4::is_multicast() const
 
 address_v4 address_v4::broadcast(const address_v4& addr, const address_v4& mask)
 {
-  return address_v4(addr.to_ulong() | ~mask.to_ulong());
+  return address_v4(addr.to_ulong() | (mask.to_ulong() ^ 0xFFFFFFFF));
 }
 
 address_v4 address_v4::netmask(const address_v4& addr)

Original file line number	Diff line number	Diff line change
`@@ -140,7 +140,7 @@ bool address_v4::is_multicast() const`
`140`	`140`
`141`	`141`	`address_v4 address_v4::broadcast(const address_v4& addr, const address_v4& mask)`
`142`	`142`	`{`
`143`		`- return address_v4(addr.to_ulong() \| ~mask.to_ulong());`
	`143`	`+ return address_v4(addr.to_ulong() \| (mask.to_ulong() ^ 0xFFFFFFFF));`
`144`	`144`	`}`
`145`	`145`
`146`	`146`	`address_v4 address_v4::netmask(const address_v4& addr)`