Skip to content

Reproducible builds #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

noirbizarre
Copy link
Member

Description

This PR commit the poetry lock file in the repository to ensure repoducible builds.

This has no impact on the produced deliverable as explain in the related section in the poetry documentation.

This PR also adds a dependabot configuration to ensure:

  • the lockfile is automatically updated with new dependencies (will trigger a build ensuring compatibility)
  • the github actions are also updated regulary

Checklist

  • Add test cases to all the changes you introduce (Not possible)
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes (Not needed)

Expected behavior

CI and developpers will now use the same tools versions (pytest,...) and build are now reproducibles (new dependencies are not pulled silently at each build anymore).
The repository receive pull requests from dependabot to update the lockfile as well as github actions.
Tje produced library is left unchanged (dependency resolution still rely on the library importer project)

Steps to Test This Pull Request

CI should go green

Additional context

Relates to: #633 (comment)

@noirbizarre
Copy link
Member Author

Superseeded by and integrated in #633 as all fixes were required together to make the CI pass again.

@noirbizarre noirbizarre closed this Dec 7, 2022
@noirbizarre noirbizarre deleted the ci/reproducible-builds branch December 7, 2022 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant