Skip to content

fix(changelog): skip non-compliant commit subjects when building changelog #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

woile
Copy link
Member

@woile woile commented Jul 16, 2022

This should fix duplicate entries in the changelog

Closes #510

Description

Checklist

  • Add test cases to all the changes you introduce
  • Run ./scripts/format and ./scripts/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Expected behavior

Only entries that have a subject compliant with conventional commits should be included.

Steps to Test This Pull Request

Run on our own commitizen:

cz ch --dry-run 2.20.5..v2.21.0

Before it was including duplicated entries, now only good ones.

Additional context

…gelog

This should fix duplicate entries in the changelog

Closes #510
@codecov
Copy link

codecov bot commented Jul 16, 2022

Codecov Report

Merging #536 (0307360) into master (a11f203) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   98.00%   98.00%           
=======================================
  Files          39       39           
  Lines        1551     1552    +1     
=======================================
+ Hits         1520     1521    +1     
  Misses         31       31           
Flag Coverage Δ
unittests 98.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/__version__.py 100.00% <100.00%> (ø)
...en/cz/conventional_commits/conventional_commits.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 234765d...0307360. Read the comment docs.

@woile woile requested a review from Lee-W July 21, 2022 13:46
@woile woile merged commit 9754d68 into master Jul 22, 2022
@woile woile deleted the fix/duplicate-changelog-entries branch July 22, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate Changelog Entries for Merged Branches
1 participant