Skip to content

docs: Fix exit code for NoCommitsFoundError #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

mmartinortiz
Copy link
Contributor

The source code indicates that the correct exit code is 3. See https://github.com/commitizen-tools/commitizen/blob/master/commitizen/exceptions.py#L10

Description

Update the documentation with the correct exit number

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

The first three entries do not apply to this PR.

Expected behavior

The documentation shows the correct information.

@codecov
Copy link

codecov bot commented Jan 5, 2022

Codecov Report

Merging #468 (308de9c) into master (1f37002) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #468   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files          39       39           
  Lines        1431     1431           
=======================================
  Hits         1403     1403           
  Misses         28       28           
Flag Coverage Δ
unittests 98.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 095f02e...308de9c. Read the comment docs.

@woile woile merged commit 0647072 into commitizen-tools:master Jan 5, 2022
@mmartinortiz mmartinortiz deleted the patch-1 branch January 5, 2022 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants