-
-
Notifications
You must be signed in to change notification settings - Fork 282
feat(changelog): add support for single version and version range #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #400 +/- ##
=======================================
Coverage 98.05% 98.06%
=======================================
Files 39 39
Lines 1441 1499 +58
=======================================
+ Hits 1413 1470 +57
- Misses 28 29 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
5a606cd
to
6585a7f
Compare
6585a7f
to
242f1cb
Compare
242f1cb
to
dfe0c4e
Compare
Lots of progress, I just have to fix and add some tests for the ranges:
|
dfe0c4e
to
f831e97
Compare
f831e97
to
4c833a1
Compare
@Lee-W can u test this PR locally? the tests are passing on my machine, not sure why they are failing now 🤔 The PR is ready 🎉 |
I might need some more time to fully review it but I just found out the reason of these failing tests. The date of tmp_git_project is decided by the time we run the tests which cannot be easily pinned by freezegun. Not sure whether there's work around for this case. If not, we might need to use traditional assertion instead of pytest-regression in the tests that depends on date. |
Thanks for the info, I understand it better now, I'm gonna check what can be done |
4a0730a
to
3084375
Compare
@Lee-W could you help me with this one? No clue why it's failing and they are passing locally. I patched the gittag date to avoid the problem with git timestamp and it works locally |
951d30e
to
1e9d5d0
Compare
@Lee-W can u take a look? I think is ready |
I'm a bit busy these days. Will try to take a look ASAP. 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's so much work 💪 Hope I can be as productive during next week's development sprint. I've left some comments and questions.
1e9d5d0
to
2020925
Compare
2020925
to
4bb9131
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for taking so long. Let's merge it!
Closes #399 #225
Description
Allows the creation of a changelog for the given version, supports:
Checklist
./script/format
and./script/test
locally to ensure this change passes linter check and testExpected behavior
Steps to Test This Pull Request
TODO
Additional context
Closes #399 #225