Skip to content

fix(changelog): generating changelog after a pre-release #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2021

Conversation

woile
Copy link
Member

@woile woile commented Jun 11, 2021

Closes #357

Description

Trying to create an incremental changelog after a prerelease failed.
This happened because of the version regex when parsing the changelog.

Checklist

  • Add test cases to all the changes you introduce
  • Run ./script/format and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually

Expected behavior

You'll see the changelog created

Steps to Test This Pull Request

# step1 init everything, not exactly relevant to the bug
git init
cz init
git add .
git commit -m "chore: add config"
git tag 0.0.1

# step2 add a dummy feature and make a pre-release
git commit -m "feat: first feat" --allow-empty
cz bump --prerelease rc --changelog

# step3 add another feature and try to do incremental changelog
git commit -m "feat: second feat" --allow-empty
cz changelog --incremental

@woile woile requested a review from Lee-W June 11, 2021 10:22
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #390 (d82727c) into master (96265ce) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #390   +/-   ##
=======================================
  Coverage   97.90%   97.90%           
=======================================
  Files          39       39           
  Lines        1381     1381           
=======================================
  Hits         1352     1352           
  Misses         29       29           
Flag Coverage Δ
unittests 97.90% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commitizen/defaults.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d44d24...d82727c. Read the comment docs.

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@woile woile merged commit 8f1b2cb into master Jun 11, 2021
@woile woile deleted the fix/357-release-candidate branch June 11, 2021 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Bump failes if Changelog exists
2 participants