Skip to content

docs(external_links): add talks, articles section to external_links #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 28, 2020

Conversation

Lee-W
Copy link
Member

@Lee-W Lee-W commented Jun 28, 2020

(Thanks for sending a pull request! Please fill in the following content to let us know better about this change.)

Types of changes

Please put an x in the box that applies

  • Documentation Update

Description

Describe what the change is

Checklist:

  • Add test cases to all the changes you introduce
  • Run ./script/lint and ./script/test locally to ensure this change passes linter check and test
  • Test the changes on the local machine manually
  • Update the documentation for the changes

Steps to Test This Pull Request

mkdocs serve
http://127.0.0.1:8000/external_links/

Expected behavior

External Links page exists

Related Issue

If applicable, reference to the issue related to this pull request.

Additional context

#208

@Lee-W Lee-W requested a review from woile June 28, 2020 05:22
@codecov
Copy link

codecov bot commented Jun 28, 2020

Codecov Report

Merging #213 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #213   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files          34       34           
  Lines         942      942           
=======================================
  Hits          901      901           
  Misses         41       41           
Flag Coverage Δ
#unittests 95.64% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2d4558...bd01c8d. Read the comment docs.

@woile woile merged commit d651ed7 into master Jun 28, 2020
@woile woile deleted the add-external-links-section branch June 28, 2020 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants