Skip to content

Rename "files" in configuration #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Lee-W opened this issue Nov 19, 2019 · 3 comments
Closed

Rename "files" in configuration #82

Lee-W opened this issue Nov 19, 2019 · 3 comments
Milestone
2.0

Comments

@Lee-W
Copy link
Member

Lee-W commented Nov 19, 2019

Goal
Make the name of this configuration more intitive

Description
The name "files" cannot be directly linked to the files that speficy version. How about "version_files"?
@woile
Copy link
Member

woile commented Nov 20, 2019

I like it, let's deprecate the files in version 2.0.0.

@woile woile added the 2.0.0 label Nov 20, 2019
Lee-W added a commit to Lee-W/commitizen that referenced this issue Dec 26, 2019
@Lee-W
refactor(commands/bump): use "version_files" internally
309a3c9 
commitizen-tools#82
@Lee-W Lee-W mentioned this issue Dec 26, 2019
Merged
Lee-W added a commit to Lee-W/commitizen that referenced this issue Dec 27, 2019
@Lee-W
refactor(commands/bump): use "version_files" internally
797ed6d 
commitizen-tools#82
@woile
Copy link
Member

woile commented Dec 30, 2019

Docs have been updated to reference to version_files

@woile woile added this to the 2.0 milestone Jan 29, 2020
Lee-W added a commit that referenced this issue Jul 25, 2020
@Lee-W
refactor(config): drop "files" configure support. Please use "version…
5b73ad4 
…_files" instead

BREAKING CHANGE:

#82
@Lee-W Lee-W mentioned this issue Jul 25, 2020
Merged
8 tasks
Lee-W added a commit that referenced this issue Jul 26, 2020
@Lee-W
refactor(config): drop "files" configure support. Please use "version…
f7809df 
…_files" instead

BREAKING CHANGE:

#82
Lee-W added a commit that referenced this issue Jul 26, 2020
@Lee-W
refactor(config): drop "files" configure support. Please use "version…
7e14955 
…_files" instead

BREAKING CHANGE:

#82
@Lee-W
Copy link
Member Author

Lee-W commented Jul 26, 2020

close by #230

@Lee-W Lee-W closed this as completed Jul 26, 2020
Lee-W added a commit that referenced this issue Jul 26, 2020
@Lee-W
refactor(config): drop "files" configure support. Please use "version…
4d36bdf 
…_files" instead

BREAKING CHANGE:

#82
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@woile @Lee-W