Skip to content

(Optional?) support for annotated tags #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SpokeyWheeler opened this issue Jan 3, 2021 · 7 comments
Closed

(Optional?) support for annotated tags #329

SpokeyWheeler opened this issue Jan 3, 2021 · 7 comments
Labels
type: feature A new enhacement proposal

Comments

@SpokeyWheeler
Copy link

Description

Currently, lightweight tags are generated by cz bump. This means you have to remember to push the tag separately from the commit, and also means you can't use --follow-tags.

Possible Solution

I did this in my clone, but I genuinely don't know if it's anything more than a hack:

I changed this line from
c = cmd.run(f"git tag {tag}")
to
c = cmd.run(f"git tag -a -m '{tag}' {tag}")

DISCLAIMER: I wouldn't know Python if it ran me over in a bus. But it seemed to work!

Additional context

N/A

Related Issue

I didn't find anything related.

@SpokeyWheeler SpokeyWheeler added the type: feature A new enhacement proposal label Jan 3, 2021
@woile
Copy link
Member

woile commented Jan 11, 2021

There's an open (abandoned) PR for annotated tags: #272
Feel free to add corrections and re-submit it. I'll try to pick it up but I'm quite busy atm

@SpokeyWheeler
Copy link
Author

Honestly, I've never written any Python in anger before. I don't feel comfortable with starting with this! :-)

@woile
Copy link
Member

woile commented Jan 12, 2021

No worries, thanks for sharing. I'll try to push this change in the coming weeks 💪🏻

@cliles cliles mentioned this issue Jan 15, 2021
4 tasks
@cliles
Copy link

cliles commented Jan 15, 2021

@woile - To help speed this up (to maybe days instead of weeks), I went ahead and looked at #272 and "adopted" it for #332.

@SpokeyWheeler
Copy link
Author

Thanks guys!

@cliles
Copy link

cliles commented Jan 24, 2021

@woile and @SpokeyWheeler - #332 is merged, this issue can be closed.

@SpokeyWheeler
Copy link
Author

Awesome! Thank you so much! 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new enhacement proposal
Projects
None yet
Development

No branches or pull requests

3 participants