You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
isort 5.X introduced profiles to make it easier to keep isort and black consistent (isort and black). I noticed that there is an issue with isort now that the test script throws errors from isort for import order but not from black. isort wants the vertically indented imports to be on one line
I can submit a PR if desired unless there is a need to stay on isort 4.x. I documented the other migration changes necessary in "Desired behavior"
Steps to reproduce / Current behavior
from ./scripts/test: poetry run isort --recursive --check-only commitizen tests
outputs:
❯ poetry run isort --recursive --check-only commitizen tests
ERROR: /Users/kyleking/Developer/Pull_Requests/commitizen/commitizen/bump.py Imports are incorrectly sorted.
ERROR: /Users/kyleking/Developer/Pull_Requests/commitizen/commitizen/commands/check.py Imports are incorrectly sorted.
ERROR: /Users/kyleking/Developer/Pull_Requests/commitizen/tests/test_cz_conventional_commits.py Imports are incorrectly sorted.
ERROR: /Users/kyleking/Developer/Pull_Requests/commitizen/tests/commands/test_changelog_command.py Imports are incorrectly sorted.
ERROR: /Users/kyleking/Developer/Pull_Requests/commitizen/tests/commands/test_check_command.py Imports are incorrectly sorted.
Desired behavior
Testing with Updating isort (4.3.21 -> 5.7.0) and the --recursive and --apply flags removed (they are now the defaults - see the isort migration guide)
Description
isort 5.X introduced profiles to make it easier to keep isort and black consistent (isort and black). I noticed that there is an issue with isort now that the test script throws errors from isort for import order but not from black. isort wants the vertically indented imports to be on one line
I can submit a PR if desired unless there is a need to stay on isort
4.x
. I documented the other migration changes necessary in "Desired behavior"Steps to reproduce / Current behavior
from
./scripts/test
:poetry run isort --recursive --check-only commitizen tests
outputs:
Desired behavior
Testing with
Updating isort (4.3.21 -> 5.7.0)
and the--recursive
and--apply
flags removed (they are now the defaults - see the isort migration guide)and the simplified TOML file:
format and test work without issue
^ Also, there is a YAML error that could possibly also be ignored and updated, see: https://msg.pyyaml.org/load
The text was updated successfully, but these errors were encountered: