Skip to content

chore: update go to 1.24.1 #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ jobs:
# Install Go!
- uses: actions/setup-go@v3
with:
go-version: "~1.23"
go-version: "~1.24"

# Check for Go linting errors!
- name: Lint Go
uses: golangci/golangci-lint-action@v6.1.1
with:
version: v1.62.2
version: v1.64.8
args: "--out-${NO_FUTURE}format colored-line-number"

- name: Lint shell scripts
Expand Down Expand Up @@ -98,7 +98,7 @@ jobs:

- uses: actions/setup-go@v3
with:
go-version: "~1.23"
go-version: "~1.24"

# Sadly the new "set output" syntax (of writing env vars to
# $GITHUB_OUTPUT) does not work on both powershell and bash so we use the
Expand Down Expand Up @@ -136,7 +136,7 @@ jobs:

- uses: actions/setup-go@v3
with:
go-version: "~1.23"
go-version: "~1.24"

# Sadly the new "set output" syntax (of writing env vars to
# $GITHUB_OUTPUT) does not work on both powershell and bash so we use the
Expand Down Expand Up @@ -170,7 +170,7 @@ jobs:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: "~1.23"
go-version: "~1.24"

- name: Go Cache Paths
id: go-cache-paths
Expand Down Expand Up @@ -223,7 +223,7 @@ jobs:
- name: Setup Go
uses: actions/setup-go@v3
with:
go-version: "~1.23"
go-version: "~1.24"

- name: Go Cache Paths
id: go-cache-paths
Expand Down Expand Up @@ -262,7 +262,7 @@ jobs:

- uses: actions/setup-go@v3
with:
go-version: "~1.23"
go-version: "~1.24"

- name: build image
run: make -j build/image/envbox
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ jobs:

- uses: actions/setup-go@v3
with:
go-version: "~1.23"
go-version: "~1.24"

- name: Go Cache Paths
id: go-cache-paths
Expand Down
2 changes: 1 addition & 1 deletion .golangci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -202,6 +202,7 @@ run:
concurrency: 4
skip-dirs:
- node_modules
- cli/cliflag
skip-files:
- scripts/rules.go
timeout: 5m
Expand All @@ -218,7 +219,6 @@ linters:
- errcheck
- errname
- errorlint
- exportloopref
- forcetypeassert
- gocritic
- gocyclo
Expand Down
3 changes: 2 additions & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module github.com/coder/envbox

go 1.23.3
go 1.24.1

// There are a few minor changes we make to Tailscale that we're slowly upstreaming. Compare here:
// https://github.com/tailscale/tailscale/compare/main...coder:tailscale:main
replace tailscale.com => github.com/coder/tailscale v1.1.1-0.20240702054557-aa558fbe5374
Expand Down
3 changes: 2 additions & 1 deletion sysboxutil/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,9 @@ import (
"os"
"time"

"github.com/coder/envbox/xunix"
"golang.org/x/xerrors"

"github.com/coder/envbox/xunix"
)

const ManagerSocketPath = "/run/sysbox/sysmgr.sock"
Expand Down
Loading