Skip to content

docs: add section for Android #4621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 15, 2021
Merged

docs: add section for Android #4621

merged 6 commits into from
Dec 15, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Dec 14, 2021

This PR piggybacks off #4536 and makes a few minor changes.

@jsjoeio jsjoeio added the docs Documentation related label Dec 14, 2021
@jsjoeio jsjoeio added this to the 4.0.0 milestone Dec 14, 2021
@jsjoeio jsjoeio self-assigned this Dec 14, 2021
@github-actions
Copy link

github-actions bot commented Dec 14, 2021 •
edited
Loading

✨ Coder.com for PR #4621 deployed! It will be updated on every commit.

@jsjoeio jsjoeio marked this pull request as ready for review December 14, 2021 22:28
@jsjoeio jsjoeio requested a review from a team as a code owner December 14, 2021 22:28
@codecov
Copy link

codecov bot commented Dec 14, 2021 •
edited
Loading

Codecov Report

Merging #4621 (0c3d6ba) into main (6e9e411) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4621   +/-   ##
=======================================
  Coverage   66.10%   66.10%           
=======================================
  Files          30       30           
  Lines        1658     1658           
  Branches      337      337           
=======================================
  Hits         1096     1096           
  Misses        477      477           
  Partials       85       85

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e9e411...0c3d6ba. Read the comment docs.

@jsjoeio jsjoeio force-pushed the jsjoeio-fix-android-docs branch from 680f5a4 to e8d3cf8 Compare December 15, 2021 00:17
The AliX Legend and others added 3 commits December 15, 2021 10:09
@jsjoeio
Add Instructions To Install 100% In Android (#4536)
7eb1a08 
* Add Instructions To Install 100% In Android

Thx

* Update android.md

Co-authored-by: Joe Previte <jjprevite@gmail.com>
@jsjoeio
docs: clean up android.md
736d1c4
@jsjoeio
docs: add android to manifest
469e92e
@jsjoeio jsjoeio force-pushed the jsjoeio-fix-android-docs branch from e8d3cf8 to 469e92e Compare December 15, 2021 17:09
code-asher
code-asher requested changes Dec 15, 2021
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a missing backtick, otherwise 👍

@code-asher
Copy link
Member

It occurs to me I should just commit the suggestion, no need to wait for the back and forth 😄

@code-asher code-asher self-requested a review December 15, 2021 19:48
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Dec 15, 2021

It occurs to me I should just commit the suggestion, no need to wait for the back and forth 😄

lol you rock :D

@repo-ranger repo-ranger bot merged commit 3059d72 into main Dec 15, 2021
@repo-ranger repo-ranger bot deleted the jsjoeio-fix-android-docs branch December 15, 2021 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees

@jsjoeio jsjoeio

Labels
docs Documentation related
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @code-asher