Skip to content

Resolve remote authority to initialize tunnel API #4105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 8, 2021
Merged

Resolve remote authority to initialize tunnel API #4105

merged 3 commits into from
Sep 8, 2021

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Sep 4, 2021

This enables the vscode.workspace.registerRemoteAuthorityResolver API to be executed.

It's specifically scoped to the "coder-link" scheme at the moment to reduce external dependency on forking VS Code functionality.

The remote host doesn't resolve to an extension host like the API expects, but instead we only utilize the tunnel functionality.

@github-actions
Copy link

github-actions bot commented Sep 4, 2021

✨ Coder.com for PR #4105 deployed! It will be updated on every commit.

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #4105 (476b9c5) into main (67b23aa) will not change coverage.
The diff coverage is n/a.

❗ Current head 476b9c5 differs from pull request most recent head c7a5263. Consider uploading reports for the commit c7a5263 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4105   +/-   ##
=======================================
  Coverage   64.12%   64.12%           
=======================================
  Files          36       36           
  Lines        1873     1873           
  Branches      379      379           
=======================================
  Hits         1201     1201           
  Misses        571      571           
  Partials      101      101           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67b23aa...c7a5263. Read the comment docs.

@kylecarbs kylecarbs marked this pull request as ready for review September 8, 2021 16:53
@kylecarbs kylecarbs requested a review from a team as a code owner September 8, 2021 16:53
@kylecarbs kylecarbs self-assigned this Sep 8, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are passing and I don't see how this would break anything.

Nice comments too 🚀

@kylecarbs kylecarbs merged commit b00afbc into main Sep 8, 2021
@kylecarbs kylecarbs deleted the link branch September 8, 2021 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants