Skip to content

Docker minimum image #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Docker minimum image #2460

wants to merge 1 commit into from

Conversation

jylenhof
Copy link

Issue I created to follow this pull request:
#2459

@jylenhof jylenhof changed the base branch from v3.7.4 to master December 14, 2020 17:14
@oxy
Copy link

oxy commented Dec 14, 2020

Thanks for your contribution! Unfortunately, I'm not sure if a slim image will fit code-server's intended use case, since developers would be connecting to the container and using it as a full-fledged development environment, and many expect to have the usual suite of command line tools.

@nhooyr
Copy link
Contributor

nhooyr commented Dec 14, 2020

Yup to echo @oxy's sentiments we intentionally used the larger image.

Perhaps we should offer a -slim variant.

@nhooyr
Copy link
Contributor

nhooyr commented Dec 18, 2020

See my comments in #2459

@nhooyr nhooyr closed this Dec 18, 2020
@nhooyr
Copy link
Contributor

nhooyr commented Dec 18, 2020

Again, I hear you @jylenhof! Appreciate your contributions. Hopefully next release we have an official slim image that satisfies your needs :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants