Skip to content

Add help information to the extension search view #2132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cmoog opened this issue Sep 23, 2020 · 4 comments
Closed

Add help information to the extension search view #2132

cmoog opened this issue Sep 23, 2020 · 4 comments
Assignees
Labels
enhancement Some improvement that isn't a feature high-priority This issue needs to be resolved ASAP
Milestone

Comments

@cmoog
Copy link
Contributor

cmoog commented Sep 23, 2020

Show a yellow or red call to action in the extension search view informing the user of all alternative extension installation methods.

@cmoog cmoog added the feature label Sep 23, 2020
@cmoog cmoog self-assigned this Oct 9, 2020
@nhooyr nhooyr added enhancement Some improvement that isn't a feature and removed feature labels Dec 7, 2020
@nhooyr nhooyr unassigned cmoog Dec 8, 2020
@nhooyr nhooyr added the high-priority This issue needs to be resolved ASAP label Dec 8, 2020
@jsjoeio jsjoeio self-assigned this Dec 14, 2020
@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 15, 2020

@cmoog

I read the discussion around your previous PR that attempted to solve this: #2185

Are we okay adding a similar message to the UI like you were planning or do you want to hold off until our extension marketplace is open source (if we move in that direction)?

@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 17, 2020

Spoke to @cmoog over Slack:

So it’s probably the case that, at this point, anything in the UI would be a big improvement from the current state. Possibly a link to open-vsix or even just a warning that the extensions are not official with a link to the code-server FAQ
But fair warning that any reference to using the MSFT marketplace assets is probably against TOS.

I'm going to brainstorm some ideas and then I'll work on this.

@nhooyr nhooyr added this to the v3.8.1 milestone Dec 18, 2020
@jsjoeio
Copy link
Contributor

jsjoeio commented Dec 18, 2020

Okay here's what I came up with.

Issue 2132(1)

Message to user:

Warning: These extensions are not official. Find open-source extensions here. See docs.

I should be able to open a PR for this next week.

@jsjoeio
Copy link
Contributor

jsjoeio commented Jan 14, 2021

Closing via #2501

@jsjoeio jsjoeio closed this as completed Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature high-priority This issue needs to be resolved ASAP
Projects
None yet
Development

No branches or pull requests

3 participants