Merge pull request #2303 from cdr/helm-db7f

Move helm from root and fix stuff in README

Author: nhooyr

.github/CODEOWNERS

@@ -1,2 +1,3 @@
-charts/code-server @Matthew-Beckett @alexgorbatchev 
-* @code-asher @nhooyr
+* @code-asher @nhooyr
+
+ci/helm-chart @Matthew-Beckett @alexgorbatchev

.github/workflows/helm_validation.yaml

@@ -19,7 +19,9 @@ main() {
     "*.yaml"
     "*.yml"
   )
-  prettier --write --loglevel=warn $(git ls-files "${prettierExts[@]}")
+  prettier --write --loglevel=warn $(
+    git ls-files "${prettierExts[@]}" | grep -v 'helm-chart'
+  )
 
   doctoc --title '# FAQ' doc/FAQ.md > /dev/null
   doctoc --title '# Setup Guide' doc/guide.md > /dev/null

ci/dev/fmt.sh

@@ -8,6 +8,7 @@ main() {
   stylelint $(git ls-files "*.css")
   tsc --noEmit
   shellcheck -e SC2046,SC2164,SC2154,SC1091,SC1090,SC2002 $(git ls-files "*.sh")
+  helm kubeval ci/helm-chart
 }
 
 main "$@"

ci/dev/lint.sh

@@ -10,8 +10,9 @@ This chart is community maintained by [@Matthew-Beckett](https://github.com/Matt
 ## TL;DR;
 
 ```console
-$ git clone https://github.com/cdr/code-server.git
-$ helm install code-server/charts/code-server
+$ git clone https://github.com/cdr/code-server
+$ cd code-server
+$ helm upgrade --install code-server ci/helm-chart
 ```
 
 ## Introduction
@@ -26,10 +27,12 @@ package manager.
 
 ## Installing the Chart
 
-To install the chart with the release name `my-release`:
+To install the chart with the release name `code-server`:
 
 ```console
-$ helm install --name my-release charts/code-server
+$ git clone https://github.com/cdr/code-server
+$ cd code-server
+$ helm upgrade --install code-server ci/helm-chart
 ```
 
 The command deploys code-server on the Kubernetes cluster in the default
@@ -40,10 +43,10 @@ that can be configured during installation.
 
 ## Uninstalling the Chart
 
-To uninstall/delete the `my-release` deployment:
+To uninstall/delete the `code-server` deployment:
 
 ```console
-$ helm delete my-release
+$ helm delete code-server
 ```
 
 The command removes all the Kubernetes components associated with the chart and
@@ -97,9 +100,9 @@ Specify each parameter using the `--set key=value[,key=value]` argument to `helm
 install`. For example,
 
 ```console
-$ helm install --name my-release \
-  --set persistence.enabled=false \
-    deployment/chart
+$ helm install code-server \
+    ci/helm-chart \
+    --set persistence.enabled=false
 ```
 
 The above command sets the the persistence storage to false.
@@ -108,7 +111,7 @@ Alternatively, a YAML file that specifies the values for the above parameters
 can be provided while installing the chart. For example,
 
 ```console
-$ helm install --name my-release -f values.yaml deployment/chart
+$ helm install code-server ci/helm-chart -f values.yaml
 ```
 
 > **Tip**: You can use the default [values.yaml](values.yaml)

charts/code-server/.helmignore renamed to ci/helm-chart/.helmignore

@@ -112,7 +112,7 @@ persistence:
   ##
   # storageClass: "-"
   accessMode: ReadWriteOnce
-  size: 1Gi
+  size: 10Gi
   annotations: {}
   # existingClaim: ""
   # hostPath: /data

charts/code-server/Chart.yaml renamed to ci/helm-chart/Chart.yaml

@@ -45,4 +45,10 @@ ENV GO111MODULE=on
 RUN go get mvdan.cc/sh/v3/cmd/shfmt
 RUN go get github.com/goreleaser/nfpm/cmd/nfpm
 
+RUN VERSION="$(curl -fsSL https://storage.googleapis.com/kubernetes-release/release/stable.txt)" && \
+    curl -fsSL "https://storage.googleapis.com/kubernetes-release/release/$VERSION/bin/linux/amd64/kubectl" > /usr/local/bin/kubectl \
+    && chmod +x /usr/local/bin/kubectl
+RUN curl -fsSL https://raw.githubusercontent.com/helm/helm/master/scripts/get-helm-3 | bash
+RUN helm plugin install https://github.com/instrumenta/helm-kubeval
+
 RUN curl -fsSL https://get.docker.com | sh

charts/code-server/README.md renamed to ci/helm-chart/README.md

@@ -12,6 +12,7 @@
 - [macOS](#macos)
 - [Standalone Releases](#standalone-releases)
 - [Docker](#docker)
+- [helm](#helm)
 
 <!-- END doctoc generated TOC please keep comment here to allow auto update -->
 
@@ -192,3 +193,7 @@ Our official image supports `amd64` and `arm64`.
 For `arm32` support there is a popular community maintained alternative:
 
 https://hub.docker.com/r/linuxserver/code-server
+
+## helm
+
+See [the chart](../ci/helm-chart).