Skip to content

Commit 4dda3cb

Browse files
committed
silance Re-defined variable from outer scope
1 parent d4756f4 commit 4dda3cb

File tree

1 file changed

+10
-8
lines changed

1 file changed

+10
-8
lines changed

git/refs/log.py

Lines changed: 10 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -46,13 +46,13 @@ def __repr__(self):
4646
def format(self):
4747
""":return: a string suitable to be placed in a reflog file"""
4848
act = self.actor
49-
time_ = self.time_
49+
time = self.time
5050
return u"{} {} {} <{}> {!s} {}\t{}\n".format(self.oldhexsha,
5151
self.newhexsha,
5252
act.name,
5353
act.email,
54-
time_[0],
55-
altz_to_utctz_str(time_[1]),
54+
time[0],
55+
altz_to_utctz_str(time[1]),
5656
self.message)
5757

5858
@property
@@ -71,7 +71,7 @@ def actor(self):
7171
return self[2]
7272

7373
@property
74-
def time_(self):
74+
def time(self):
7575
"""time as tuple:
7676
7777
* [0] = int(time)
@@ -83,14 +83,16 @@ def message(self):
8383
"""Message describing the operation that acted on the reference"""
8484
return self[4]
8585

86+
# skipcq: PYL-W0621
8687
@classmethod
87-
def new(cls, oldhexsha, newhexsha, actor, time_, tz_offset, message):
88+
def new(cls, oldhexsha, newhexsha, actor, time, tz_offset, message):
8889
""":return: New instance of a RefLogEntry"""
8990
if not isinstance(actor, Actor):
9091
raise ValueError("Need actor instance, got %s" % actor)
9192
# END check types
92-
return RefLogEntry((oldhexsha, newhexsha, actor, (time_, tz_offset), message))
93+
return RefLogEntry((oldhexsha, newhexsha, actor, (time, tz_offset), message))
9394

95+
# skipcq: PYL-W0621
9496
@classmethod
9597
def from_line(cls, line):
9698
""":return: New RefLogEntry instance from the given revlog line.
@@ -121,9 +123,9 @@ def from_line(cls, line):
121123
# END handle missing end brace
122124

123125
actor = Actor._from_string(info[82:email_end + 1])
124-
time_, tz_offset = parse_date(info[email_end + 2:])
126+
time, tz_offset = parse_date(info[email_end + 2:])
125127

126-
return RefLogEntry((oldhexsha, newhexsha, actor, (time_, tz_offset), msg))
128+
return RefLogEntry((oldhexsha, newhexsha, actor, (time, tz_offset), msg))
127129

128130

129131
class RefLog(list, Serializable):

0 commit comments

Comments
 (0)