Fix result.rowCount being a string instead of a number via native bindings. #734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -8,6 +8,7 @@ test('fires callback with results', function() { | |||
| client.query('SELECT 1 as num', assert.calls(function(err, result) { | |||
| assert.isNull(err); | |||
| assert.equal(result.rows[0].num, 1); | |||
| assert.equal(result.rowCount, 1); | |||
There was a problem hiding this comment.
I think you might want to use assert.strictEqual here - doing an assert.equals basically does "1" == 1 which is true. What do you think?
|
Other than that one little thing, this looks great! |
|
You're right, I missed |
|
No worries! This is fabulous now! Thank you so much!! 🙆♀️ 🙇 |
brianc
added a commit
that referenced
this pull request
Feb 22, 2015
Fix result.rowCount being a string instead of a number via native bindings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Btw, once you drop support for node 0.8 you can drop the
parseIntradix, as it should default to 10.