Skip to content

In order for the command line execution to finish #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2015
Merged

In order for the command line execution to finish #729

merged 1 commit into from
Feb 21, 2015

Conversation

wallymathieu
Copy link
Contributor

In the example, it looks like it's missing a client end.

@brianc
Copy link
Owner

brianc commented Feb 21, 2015

Thanks! Sorry for the delay in getting to this - been buried recently.

brianc added a commit that referenced this pull request Feb 21, 2015
In order for the command line execution to finish
@brianc brianc merged commit 8c10612 into brianc:master Feb 21, 2015
@wallymathieu
Copy link
Contributor Author

No problem!

@wallymathieu wallymathieu deleted the patch-1 branch February 21, 2015 14:20
@dogles
Copy link

dogles commented Feb 21, 2015

Is this correct? It seems like this would destroy the connection, which is the whole point of the connection pooling example...

@wallymathieu
Copy link
Contributor Author

Sounds like I browsed the code and didn't read the comment. As the code reads, it reads like a command line app. Perhaps an express site that answers with some info would be clearer?

@brianc brianc mentioned this pull request Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants