Skip to content

Fix build when escape functions are not supported in libpq #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 1, 2013

Conversation

rpedela
Copy link
Contributor

@rpedela rpedela commented Jul 23, 2013

If the PG version < 9.0.0 then the native escape functions will not be exported, and will fallback to the JS versions.

@rpedela
Copy link
Contributor Author

rpedela commented Jul 23, 2013

Any idea why the tests are failing? Looks like a Ubuntu PPA issue. The escape tests passed though.

@rpedela
Copy link
Contributor Author

rpedela commented Jul 29, 2013

Alright the tests passed and I did a "git rebase". Sorry I did not do that before. I think the best way to ensure this works right is to modify the tests to download, install, test PG 8.4 as well as 9.x.

@brianc
Copy link
Owner

brianc commented Jul 30, 2013

Yeah I need to get a postgres 8.x install going. Maybe on a vps or something.

@brianc
Copy link
Owner

brianc commented Aug 1, 2013

@rpedela thank you soooo much for this & your patience. I was traveling last week & had personal stuff this weekend so sorry it's taken me a while to get to it. I'm booting a droplet right now to test postgres v8.x compilation. After that....merge.

You've been doing some pretty solid pull requests recently. If you have any interest in being a maintainer I'd love to discuss it over an issue in github on this repository to keep transparency w/ the community at a maximum. If you're interested just open an issue. :)

@brianc
Copy link
Owner

brianc commented Aug 1, 2013

Tested & verified with postgres v8.4!

brianc added a commit that referenced this pull request Aug 1, 2013
Fix build when escape functions are not supported in libpq
@brianc brianc merged commit a17f7fc into brianc:master Aug 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants