Found a bug. #19
Merged
Found a bug. #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ug by making the query smaller (char count).
|
Ah thanks so much! I'll get this looked at & fixed today. |
|
I merged your test in (can never have too many tests, right?!) and added another one to test the scenario even harder, but still I'm unable to reproduce on any of the following environments:
Which version of node, postgres, and which OS are you on? |
|
PostgreSQL 9.0.1 on x86_64-apple-darwin10.5.0, compiled by GCC i686-apple-darwin10-gcc-4.2.1 (GCC) 4.2.1 (Apple Inc. build 5664), 64-bit node v0.3.1 I only get the error every 4 - 8 time i run the test. I know its a bit crazy.. |
|
I will upgrade to latest node later today and try again. |
|
I cant recreate it in 0.4.2.. So i guess it had something to do with node. I hope you didn't spend to much time on this! |
brianc
added a commit
that referenced
this pull request
Dec 18, 2019
Fix require for webpack compatibility
brianc
pushed a commit
that referenced
this pull request
Dec 27, 2019
* Added URL parsing example * Typos and cleanup * Last typo
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't fix it, but i did write a test that triggers it.
I hope this helps.
Best Regards Björn Blomqvist