-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
reapIntervalMillis from generic-pool #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We prefer pull requests over patches. Anyway. I added your patch to my fork. Maybe you can provide a tests as well? Take a look at: https://github.com/brianc/node-postgres/tree/master/test/integration/connection-pool |
I dig this. A test would be preferable though it's really just a pass-through into the generic pool itself which is tested. Is there an actual pull request somewhere? |
Closed
thanx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please commit this:
diff --git a/index.js b/index.js
index d96d44c..ac2991e 100644
--- a/index.js
+++ b/index.js
@@ -76,7 +76,8 @@ PG.prototype.connect = function(config, callback) {
client.end();
},
max: defaults.poolSize,
});
return pool.acquire(cb);
}
The text was updated successfully, but these errors were encountered: