Skip to content

reapIntervalMillis from generic-pool #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
progman opened this issue Feb 1, 2012 · 3 comments
Closed

reapIntervalMillis from generic-pool #89

progman opened this issue Feb 1, 2012 · 3 comments

Comments

@progman
Copy link

progman commented Feb 1, 2012

Please commit this:

diff --git a/index.js b/index.js
index d96d44c..ac2991e 100644
--- a/index.js
+++ b/index.js
@@ -76,7 +76,8 @@ PG.prototype.connect = function(config, callback) {
client.end();
},
max: defaults.poolSize,

  • idleTimeoutMillis: defaults.poolIdleTimeout
  • idleTimeoutMillis: defaults.poolIdleTimeout,
  • reapIntervalMillis: defaults.reapIntervalMillis
    });
    return pool.acquire(cb);
    }
@booo
Copy link
Contributor

booo commented Feb 1, 2012

We prefer pull requests over patches. Anyway. I added your patch to my fork. Maybe you can provide a tests as well? Take a look at: https://github.com/brianc/node-postgres/tree/master/test/integration/connection-pool

@brianc
Copy link
Owner

brianc commented Feb 1, 2012

I dig this. A test would be preferable though it's really just a pass-through into the generic pool itself which is tested. Is there an actual pull request somewhere?

@booo booo mentioned this issue Feb 1, 2012
@progman
Copy link
Author

progman commented Feb 2, 2012

thanx

@progman progman closed this as completed Feb 2, 2012
brianc pushed a commit that referenced this issue Feb 3, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants