Skip to content

Connection using SSL even though I have SSL set to false in options #848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ym-mqual opened this issue Aug 31, 2015 · 5 comments
Closed

Comments

@ym-mqual
Copy link

Stems from line 44 in the connection-parameters.js. I corrected it as follows:

OLD: config.ssl || useSsl(); -this is a problem if you send in false.
CORRECTED: this.ssl = typeof config.ssl === 'undefined' ? useSsl() : config.ssl;

@ym-mqual
Copy link
Author

Actually thought about it again and this is probably better:

this.ssl = typeof config.ssl === 'boolean' ? config.ssl : useSsl();

@simonv3
Copy link

simonv3 commented Nov 28, 2015

👍 I can confirm that this is an issue, and that fixes it.

@joskuijpers
Copy link
Contributor

joskuijpers commented Jun 20, 2016

Can you submit a Pull Request?

Made a PR myself

joskuijpers added a commit to joskuijpers/node-postgres that referenced this issue Jun 20, 2016
@joskuijpers
Copy link
Contributor

@brianc This can be closed now

@brianc
Copy link
Owner

brianc commented Jun 21, 2016

@joskuijpers you are so helpful! Thank you!!

@brianc brianc closed this as completed Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants