-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Connection using SSL even though I have SSL set to false in options #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Actually thought about it again and this is probably better: this.ssl = typeof config.ssl === 'boolean' ? config.ssl : useSsl(); |
👍 I can confirm that this is an issue, and that fixes it. |
Made a PR myself |
joskuijpers
added a commit
to joskuijpers/node-postgres
that referenced
this issue
Jun 20, 2016
brianc
pushed a commit
that referenced
this issue
Jun 21, 2016
@brianc This can be closed now |
@joskuijpers you are so helpful! Thank you!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Stems from line 44 in the connection-parameters.js. I corrected it as follows:
OLD: config.ssl || useSsl(); -this is a problem if you send in false.
CORRECTED: this.ssl = typeof config.ssl === 'undefined' ? useSsl() : config.ssl;
The text was updated successfully, but these errors were encountered: