Skip to content

Update ifSerial.adoc #826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Update ifSerial.adoc #826

merged 2 commits into from
Nov 7, 2023

Conversation

rohoog
Copy link
Contributor

@rohoog rohoog commented Apr 23, 2021

I got bitten by this delay in a loop that otherwise would easily keep up with interrupts. I think users should be aware of it! One would not expect such a line status return to take any time at all.

I got bitten by this delay in a loop that otherwise would easily keep up with interrupts. I think users should be aware of it!
@CLAassistant
Copy link

CLAassistant commented Apr 23, 2021

CLA assistant check
All committers have signed the CLA.

per1234
per1234 previously requested changes May 7, 2022
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your suggestion @rohoog. Please move this information to the standard "Notes and Warnings" section at the standard position on the page as shown in the reference sample:

https://raw.githubusercontent.com/arduino/reference-en/master/AsciiDoc_sample/Reference_Terms/AsciiDoc_Template-Single_Entity.adoc

@per1234 per1234 added on hold The PR should not be merged at this time enhancement labels May 7, 2022
@rohoog
Copy link
Contributor Author

rohoog commented May 18, 2022

I moved the remark. Sorry for the delay.

@rohoog rohoog requested a review from per1234 May 18, 2022 20:17
@per1234 per1234 dismissed their stale review June 27, 2022 06:43

Requested change has been made. Thanks!

@per1234 per1234 removed the on hold The PR should not be merged at this time label Jun 27, 2022
@alranel alranel merged commit 055374f into arduino:master Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants